Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the Solarian ship prefix from "SGSV" to "SCSV" #2831

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

JimKil3
Copy link
Contributor

@JimKil3 JimKil3 commented Mar 11, 2024

About The Pull Request

Title. Just a find and replace from "SGSV" to "SCSV"

Why It's Good For The Game

"SolGov" isn't an official name for the Most Serene Solar and Intersolar Confederation, so "SolGov Space Vessel" doesn't really make sense. "Solar Confederation Space Vessel" does make sense, though.

Changelog

🆑
tweak: The Solarian ship prefix is now "SCSV," not "SGSV"
/🆑

@JimKil3 JimKil3 requested a review from a team as a code owner March 11, 2024 08:38
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Mar 11, 2024
Copy link
Member

@Imaginos16 Imaginos16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this.

@thgvr thgvr added this pull request to the merge queue Mar 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024
@thgvr thgvr added this pull request to the merge queue Mar 12, 2024
Merged via the queue into shiptest-ss13:master with commit 0052857 Mar 12, 2024
14 checks passed
@JimKil3 JimKil3 deleted the scsv branch March 18, 2024 05:58
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Mar 23, 2024
…#2831)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
Title. Just a find and replace from "SGSV" to "SCSV"
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
"SolGov" isn't an official name for the Most Serene Solar and Intersolar
Confederation, so "SolGov Space Vessel" doesn't really make sense.
"Solar Confederation Space Vessel" does make sense, though.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->
:cl:
tweak: The Solarian ship prefix is now "SCSV," not "SGSV"
/🆑

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants