Constructable exercise equipment #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feex
Bolts description for weight machines. Adds crafting for weight machines.
Fixes error
Can construct punching bag from cloth, and deconstruct with wirecutters.
Adds cut var, adjusts examine behavior for punching bags.
|
I’d actually prefer if exercise equipment could be unanchored and dragged in addition to deconstructed. Maybe allow for unanchoring weight benches with a wrench and deconstructing with a screwdriver? |
It's been added, and the punching bag can also be unwrenched and wirecuttered |
west3436
reviewed
Mar 20, 2024
west3436
reviewed
Mar 20, 2024
west3436
reviewed
Mar 20, 2024
west3436
reviewed
Mar 20, 2024
west3436
reviewed
Mar 20, 2024
|
Typos have been fixed, the extraneous TRUE returns are removed. Also fixed a typo I noticed. Bolt and unbolt messages were backwards. |
|
Seems like the TRUEs are necessary, but now Rust is failing. Agh. |
|
Typos are fixed, the the TRUEs are necessary to prevent the tools from hitting the benches or the bag after the action. Everything should hopefully be good now. |
MarkSuckerberg
previously requested changes
Mar 27, 2024
|
Suggested changes have been added, and it looks like everything works |
thgvr
requested changes
Mar 30, 2024
|
Spans have all been converted to macros as requested |
thgvr
approved these changes
Apr 11, 2024
shiptest-server
pushed a commit
that referenced
this pull request
Apr 11, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Apr 12, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> - Punching bags can now be constructed from 5 cloth and deconstructed with a wirecutter. - Bench presses and chest presses can be constructed from 5 metal and deconstructed with a wrench. ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> You no longer need to smash apart the exercise equipment like a caveman, and offers players some more freedom in how they want to decorate or arrange their ships. ## Changelog :cl: add: Punching bags can be built with 5 cloth. add: Bench press and chest press can be built with 5 metal. add: Exercise equipment can be deconstructed. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Apr 15, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> - Punching bags can now be constructed from 5 cloth and deconstructed with a wirecutter. - Bench presses and chest presses can be constructed from 5 metal and deconstructed with a wrench. ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> You no longer need to smash apart the exercise equipment like a caveman, and offers players some more freedom in how they want to decorate or arrange their ships. ## Changelog :cl: add: Punching bags can be built with 5 cloth. add: Bench press and chest press can be built with 5 metal. add: Exercise equipment can be deconstructed. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
You no longer need to smash apart the exercise equipment like a caveman, and offers players some more freedom in how they want to decorate or arrange their ships.
Changelog
🆑
add: Punching bags can be built with 5 cloth.
add: Bench press and chest press can be built with 5 metal.
add: Exercise equipment can be deconstructed.
/:cl: