Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds storage to helmets, which can overlay certain items in them #2845

Merged
merged 6 commits into from
May 9, 2024

Conversation

meemofcourse
Copy link
Contributor

About The Pull Request

imagen
Adds a whitelisted storage component to helmets, and a variable that determines if they should process overlays. Features codersprites.
imagen

Why It's Good For The Game

  • It looks nice.

Changelog

🆑
add: Helmets now have a small, two-item storage. You can put goggles in there, and it might overlay them.
/:cl:

@meemofcourse meemofcourse requested a review from a team as a code owner March 21, 2024 00:59
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Mar 21, 2024
@github-actions github-actions bot removed the DME Edit label Mar 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Self-explanatory, it's so #2845 doesn't look goofy when it's merged.

![image](https://github.com/shiptest-ss13/Shiptest/assets/77556824/49b8e499-72db-490f-b6b8-29ffd78252ef)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Fixes some silliness.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: PositiveEntropy
imageadd: Inteq helmets no longer have in-built goggles.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@Gorionus Gorionus mentioned this pull request Mar 27, 2024
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 12, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Self-explanatory, it's so shiptest-ss13#2845 doesn't look goofy when it's merged.

![image](https://github.com/shiptest-ss13/Shiptest/assets/77556824/49b8e499-72db-490f-b6b8-29ffd78252ef)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Fixes some silliness.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: PositiveEntropy
imageadd: Inteq helmets no longer have in-built goggles.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 15, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Self-explanatory, it's so shiptest-ss13#2845 doesn't look goofy when it's merged.

![image](https://github.com/shiptest-ss13/Shiptest/assets/77556824/49b8e499-72db-490f-b6b8-29ffd78252ef)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Fixes some silliness.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: PositiveEntropy
imageadd: Inteq helmets no longer have in-built goggles.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@thgvr
Copy link
Member

thgvr commented Apr 16, 2024

This needs to be able to support species alts

@rye-rice rye-rice added this pull request to the merge queue May 9, 2024
Merged via the queue into shiptest-ss13:master with commit 2dd6ccd May 9, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request May 11, 2024
…ptest-ss13#2845)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/cc1a9bfc-5f6a-4091-8ea5-695c5b1e1ca7)
Adds a whitelisted storage component to helmets, and a variable that
determines if they should process overlays. Features codersprites.

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/8e874d88-885b-4909-9f5d-81be1ae4f5ae)


<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
  * It looks nice.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Helmets now have a small, two-item storage. You can put goggles in
there, and it might overlay them.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants