Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dswords being invisible #2855

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

meemofcourse
Copy link
Contributor

About The Pull Request

Whenever a dsword was toggled, it would use dualsaber_color1, but the icons were only named dualsaber_color.

Why It's Good For The Game

people should probably know that you have a dual saber in your hand

Changelog

🆑
fix: Dual sabers should no longer be invisible
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Mar 24, 2024
@Imaginos16 Imaginos16 enabled auto-merge March 25, 2024 03:14
@Imaginos16 Imaginos16 added this pull request to the merge queue Mar 25, 2024
Merged via the queue into shiptest-ss13:master with commit f0db0fa Mar 25, 2024
14 checks passed
@meemofcourse meemofcourse deleted the dsaber-fix branch March 25, 2024 19:12
MarkSuckerberg pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Mar 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Whenever a dsword was toggled, it would use dualsaber_color1, but the
icons were only named dualsaber_color.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
people should probably know that you have a dual saber in your hand

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: Dual sabers should no longer be invisible
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants