Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can plunge geysers with a normal plunger and removes reinforced plungers #2864

Merged
merged 4 commits into from
Mar 30, 2024

Conversation

Gristlebee
Copy link
Contributor

@Gristlebee Gristlebee commented Mar 26, 2024

About The Pull Request

You can plunger and activate geysers with a standard plunger.

Also removes reinforced plungers since they don't do anything anymore. and adds a normal plunger to the Schmiedeberg in it's place.

Why It's Good For The Game

The reinforced plunger was effectively made unobtainable with #2617 removing it from the vendor stock, aside from the one ship it's currently mapped on (Schmiedeberg), with no other available sources. Geysers are basically inaccessible to the vast majority of players as a result.

Even then, having the reinforced plunger only obtainable in the medical vendor gated it behind a small subset of ships, and meant it was almost never seen anyways.

This will make geysers usable again and the increased accessibility hopefully means it will actually be interacted with.

Changelog

🆑
tweak: Geysers can now be plunged with a normal plunger.
tweak: Schmiedeberg's reinforced plunger replaced with a normal plunger
del: Reinforced plungers
imagedel: Reinforced plunger sprites
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Mar 26, 2024
@Anticept
Copy link
Contributor

var/reinforced = FALSE //whether we do heavy duty stuff like geysers

This comment probably shouldn't be left to mentioning geysers either.

@Gristlebee
Copy link
Contributor Author

This comment probably shouldn't be left to mentioning geysers either.

Comment has been edited.

@MarkSuckerberg
Copy link
Member

does reinforced do anything besides geysers?

if not maybe we should just fully remove reinforced plungers

@Gristlebee
Copy link
Contributor Author

does reinforced do anything besides geysers?

if not maybe we should just fully remove reinforced plungers

Yeah, their only purpose was for geysers. I can remove then.

@MarkSuckerberg
Copy link
Member

awesome awesome 👍

@Gristlebee Gristlebee requested review from a team as code owners March 27, 2024 02:36
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. labels Mar 27, 2024
@Gristlebee Gristlebee changed the title You can plunge geysers with a normal plunger You can plunge geysers with a normal plunger and removes reinforced plungers Mar 27, 2024
@Gristlebee
Copy link
Contributor Author

Gristlebee commented Mar 27, 2024

Reinforced plungers have been obliterated and PR has been updated to reflect.

@thgvr
Copy link
Member

thgvr commented Mar 30, 2024

ok

@thgvr thgvr added this pull request to the merge queue Mar 30, 2024
Merged via the queue into shiptest-ss13:master with commit 777b3d9 Mar 30, 2024
14 checks passed
@Gristlebee Gristlebee deleted the Plungers branch April 10, 2024 04:35
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 12, 2024
…lungers (shiptest-ss13#2864)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
You can plunger and activate geysers with a standard plunger. 

Also removes reinforced plungers since they don't do anything anymore.
and adds a normal plunger to the Schmiedeberg in it's place.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
The reinforced plunger was effectively made unobtainable with shiptest-ss13#2617
removing it from the vendor stock, aside from the one ship it's
currently mapped on (Schmiedeberg), with no other available sources.
Geysers are basically inaccessible to the vast majority of players as a
result.

Even then, having the reinforced plunger only obtainable in the medical
vendor gated it behind a small subset of ships, and meant it was almost
never seen anyways.

This will make geysers usable again and the increased accessibility
hopefully means it will actually be interacted with.


<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: Geysers can now be plunged with a normal plunger.
tweak: Schmiedeberg's reinforced plunger replaced with a normal plunger
del: Reinforced plungers
imagedel: Reinforced plunger sprites
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 15, 2024
…lungers (shiptest-ss13#2864)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
You can plunger and activate geysers with a standard plunger. 

Also removes reinforced plungers since they don't do anything anymore.
and adds a normal plunger to the Schmiedeberg in it's place.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
The reinforced plunger was effectively made unobtainable with shiptest-ss13#2617
removing it from the vendor stock, aside from the one ship it's
currently mapped on (Schmiedeberg), with no other available sources.
Geysers are basically inaccessible to the vast majority of players as a
result.

Even then, having the reinforced plunger only obtainable in the medical
vendor gated it behind a small subset of ships, and meant it was almost
never seen anyways.

This will make geysers usable again and the increased accessibility
hopefully means it will actually be interacted with.


<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: Geysers can now be plunged with a normal plunger.
tweak: Schmiedeberg's reinforced plunger replaced with a normal plunger
del: Reinforced plungers
imagedel: Reinforced plunger sprites
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants