Ports timed_action_flags & centralizes do_afters #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, you guys had |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Merged
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sun-Soaked
approved these changes
Jun 1, 2024
Signed-off-by: Sun-Soaked <[email protected]>
Signed-off-by: Sun-Soaked <[email protected]>
shiptest-server
pushed a commit
that referenced
this pull request
Jun 2, 2024
SomeguyManperson
added a commit
that referenced
this pull request
Jun 5, 2024
This reverts commit 41aedd0.
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jun 22, 2024
Ports: - tgstation/tgstation#54409 - tgstation/tgstation#55172 - BeeStation/BeeStation-Hornet#8635 - BeeStation/BeeStation-Hornet#8678 Fix to shiptest-ss13#2899 - tgstation/tgstation#82413 <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> This PR moves unique do_after behavior under a flag system. It also deletes do_mob & do_atom, and centralizes them under do_after <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Makes do_after behavior much more granular and easy to edit. Flag systems are straight forward, and the docs I added tell you exactly what their behavior is. do_mob and do_atom are essentially just snowflake versions of do_after, its much cleaner just to put em under the same umbrella. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: rkz, Benjamin(benbot16), Rohesie, Qustinnus, jlsnow301 refactor: refactored do_afters to use timed_action_flags for unique args code: centralized do_mob and do_atom into do_after /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Sun-Soaked <[email protected]> Co-authored-by: Sun-Soaked <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports:
Fix to #2899
About The Pull Request
This PR moves unique do_after behavior under a flag system.
It also deletes do_mob & do_atom, and centralizes them under do_after
Why It's Good For The Game
Makes do_after behavior much more granular and easy to edit. Flag systems are straight forward, and the docs I added tell you exactly what their behavior is.
do_mob and do_atom are essentially just snowflake versions of do_after, its much cleaner just to put em under the same umbrella.
Changelog
🆑 rkz, Benjamin(benbot16), Rohesie, Qustinnus, jlsnow301
refactor: refactored do_afters to use timed_action_flags for unique args
code: centralized do_mob and do_atom into do_after
/:cl: