Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clears up the graffiti list, adds hobocode graffiti. #2887

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

goober3
Copy link
Member

@goober3 goober3 commented Apr 10, 2024

About The Pull Request

This PR:
Removes these graffiti sprites.
73a8f5806f023f6444d442b37162fced

Adds a new set of codersprite graffiti, which is based on hobo symbols.
74bd1076299c63cafd7822ced40010e5
image

Why It's Good For The Game

We've got a bunch of cruft in spraycan graffiti, including a ton of weird anti-furry stuff, and references that don't make sense in our setting. This PR removes the bad stuff, and adds some new graffiti to fill the space.

Changelog

🆑
add: A new graffiti section for code symbols has been added.
del: Some graffiti has been removed from the spraycan list.
/🆑

@goober3 goober3 requested a review from a team as a code owner April 10, 2024 23:36
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Apr 10, 2024
@Sadhorizon
Copy link
Contributor

Sadhorizon commented Apr 11, 2024

The Revolution one kinda looks like the GEC poster. I think it'd be a neat factional grafitti, after some minor adjustments. Up to you ofc, I'm just sharing some thoughts.
obraz

@goober3
Copy link
Member Author

goober3 commented Apr 11, 2024

c23b29df5b3ad1b104e9027b8d99abfa
why don't you fight me, pal. why don't we take this outside, huh??

@goober3
Copy link
Member Author

goober3 commented Apr 11, 2024

The Revolution one kinda looks like the GEC poster. I think it'd be a neat factional grafitti, after some minor adjustments. Up to you ofc, I'm just sharing some thoughts. obraz

yeah, that's a good point. maybe.

@Hlscientist
Copy link

The Revolution one kinda looks like the GEC poster. I think it'd be a neat factional grafitti, after some minor adjustments. Up to you ofc, I'm just sharing some thoughts. obraz

Seconded, GEC needs some love!

@thgvr thgvr added this pull request to the merge queue Apr 16, 2024
Merged via the queue into shiptest-ss13:master with commit 1b27b00 Apr 16, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 16, 2024
)

## About The Pull Request
This PR:
Removes these graffiti sprites.

![73a8f5806f023f6444d442b37162fced](https://github.com/shiptest-ss13/Shiptest/assets/118859017/866e500a-ad54-4209-b33f-547444b1e0e0)

Adds a new set of codersprite graffiti, which is based on hobo symbols. 

![74bd1076299c63cafd7822ced40010e5](https://github.com/shiptest-ss13/Shiptest/assets/118859017/ce57deb2-b42a-4e0e-8cd3-7b37b924267b)

![image](https://github.com/shiptest-ss13/Shiptest/assets/118859017/6b8ea581-b26e-4cc4-9e40-93c6207973de)

## Why It's Good For The Game
We've got a bunch of cruft in spraycan graffiti, including a ton of
weird anti-furry stuff, and references that don't make sense in our
setting. This PR removes the bad stuff, and adds some new graffiti to
fill the space.

## Changelog

🆑
add: A new graffiti section for code symbols has been added.
del: Some graffiti has been removed from the spraycan list.
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS added a commit to CeladonSS13/Shiptest that referenced this pull request Apr 16, 2024
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Apr 16, 2024
)

## About The Pull Request
This PR:
Removes these graffiti sprites.

![73a8f5806f023f6444d442b37162fced](https://github.com/shiptest-ss13/Shiptest/assets/118859017/866e500a-ad54-4209-b33f-547444b1e0e0)

Adds a new set of codersprite graffiti, which is based on hobo symbols. 

![74bd1076299c63cafd7822ced40010e5](https://github.com/shiptest-ss13/Shiptest/assets/118859017/ce57deb2-b42a-4e0e-8cd3-7b37b924267b)

![image](https://github.com/shiptest-ss13/Shiptest/assets/118859017/6b8ea581-b26e-4cc4-9e40-93c6207973de)

## Why It's Good For The Game
We've got a bunch of cruft in spraycan graffiti, including a ton of
weird anti-furry stuff, and references that don't make sense in our
setting. This PR removes the bad stuff, and adds some new graffiti to
fill the space.

## Changelog

🆑
add: A new graffiti section for code symbols has been added.
del: Some graffiti has been removed from the spraycan list.
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@Valorium-RB
Copy link

Reason for getting rid of the star graffiti? That seems like a pretty standard icon.

@goober3
Copy link
Member Author

goober3 commented Apr 17, 2024

Reason for getting rid of the star graffiti? That seems like a pretty standard icon.

oh honestly i just didn't want people seeing it and thinking like. pentagrams??? satan real???? truthfullly it doesn't make much of a difference either way.

@Valorium-RB
Copy link

Reason for getting rid of the star graffiti? That seems like a pretty standard icon.

oh honestly i just didn't want people seeing it and thinking like. pentagrams??? satan real???? truthfullly it doesn't make much of a difference either way.

Fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants