Gun attachments #2917
Merged
Gun attachments #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and CallAsync to INVOKE_ASYNC
bayonet stabby
fix reach code
thgvr
previously requested changes
Jul 6, 2024
There was a problem hiding this comment.
Some things, nitpicks, code styling, weird bits
Please remember newlines at the end of your files - it's missing a lot and the linter really doesn't like it
Autodoc all of the attachment stuff as well, left comments.
Could be worth making an explanation/guide at the top of the attachments on what everything does and how to make a new one correctly.
code/modules/mob/living/simple_animal/hostile/megafauna/codename_claw.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
Co-authored-by: thgvr <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
shiptest-server
pushed a commit
that referenced
this pull request
Jul 15, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Jul 20, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Finishing #145 Requires shiptest-ss13#2877 <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: refactor: refactored attachments to be modular /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: FalloutFalcon <[email protected]> Signed-off-by: Theos <[email protected]> Co-authored-by: Matthew <[email protected]> Co-authored-by: Zephyr <[email protected]> Co-authored-by: Theos <[email protected]> Co-authored-by: thgvr <[email protected]>
FalloutFalcon
added a commit
to FalloutFalcon/ShiptestF
that referenced
this pull request
Aug 30, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Finishing shiptest-ss13#145 Requires shiptest-ss13#2877 <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: refactor: refactored attachments to be modular /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: FalloutFalcon <[email protected]> Signed-off-by: Theos <[email protected]> Co-authored-by: Matthew <[email protected]> Co-authored-by: Zephyr <[email protected]> Co-authored-by: Theos <[email protected]> Co-authored-by: thgvr <[email protected]>
FalloutFalcon
pushed a commit
to FalloutFalcon/ShiptestF
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Finishing #145
Requires #2877
Why It's Good For The Game
Changelog
🆑
refactor: refactored attachments to be modular
/:cl: