Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe Managment #2934

Merged
merged 4 commits into from
May 20, 2024
Merged

Conversation

FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Apr 24, 2024

About The Pull Request

Sorts all the crafting recipes into there own category while removing some "cruft" recipes
Removes some recipes but some of them are just because they already exist in sheet recipes
Look at the last commit for recipes removed

Part 1 of Spaceman detribalization because I have to split up this pr or tghvr will behead me

Why It's Good For The Game

Makes it easier to manage recipes and removes some bad ones to clean up the recipe list

Changelog

🆑
del: deleted some bad recipes like a golden horn, black carpet, aitater, and legion staff
code: organized recipe files
/:cl:

@github-actions github-actions bot added DME Edit Code change Watch something violently break. labels Apr 24, 2024
@rye-rice rye-rice added this pull request to the merge queue May 20, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 20, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Sorts all the crafting recipes into there own category while removing
some "cruft" recipes
Removes some recipes but some of them are just because they already
exist in sheet recipes
Look at the last commit for recipes removed

Part 1 of Spaceman detribalization because I have to split up this pr or
tghvr will behead me

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Makes it easier to manage recipes and removes some bad ones to clean up
the recipe list
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
del: deleted some bad recipes like a golden horn, black carpet, aitater,
and legion staff
code: organized recipe files
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@rye-rice rye-rice added this pull request to the merge queue May 20, 2024
Merged via the queue into shiptest-ss13:master with commit 732dab1 May 20, 2024
14 checks passed
@FalloutFalcon FalloutFalcon deleted the recipe-orginizationn branch May 24, 2024 07:11
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request May 25, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Sorts all the crafting recipes into there own category while removing
some "cruft" recipes
Removes some recipes but some of them are just because they already
exist in sheet recipes
Look at the last commit for recipes removed

Part 1 of Spaceman detribalization because I have to split up this pr or
tghvr will behead me

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Makes it easier to manage recipes and removes some bad ones to clean up
the recipe list
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
del: deleted some bad recipes like a golden horn, black carpet, aitater,
and legion staff
code: organized recipe files
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants