-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGR Rework Part 1: Clothing and Roles! #2945
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
Tile placing is hard. Thank you for your service.
DME Edit
Sprites
A bikeshed full of soulless bikes.
Code change
Watch something violently break.
labels
Apr 29, 2024
these are lovely! That shade of green is oddly captivating |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
thgvr
reviewed
May 5, 2024
//Jumpsuits// | ||
///////////// | ||
|
||
/obj/item/clothing/under/syndicate/ngr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any specific reason these are all syndicate/
subtype?
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request HELLO HELLO EVERYONE, IT'S THAT TIME OF THE YEAR AGAIN! ANOTHER FACTION REWORK LET'S GOOOO WOOOOO YEAH WOOOOO! ON THE MENU TODAY: THE NEW GORLEX REPUBLIC! ![image](https://github.com/shiptest-ss13/Shiptest/assets/77556824/b7790168-483a-4d69-9566-d13880d423de) This PR updates ALL the visuals of our favorite boys in beige. Sadly this does not include new ships, nor does this include new guns. You're gonna have to wait on that for now. This PR adds three new roles that are currently not in an NGR ship (the Hyena), which are: - The Operative (think of it like the Enforcer) - The Medical Doctor - The Lieutenant (Second-In-Command role) The Junior Agent role has now been renamed to Initiate. Any new equipment analogous to old equipment in the Hyena has been fully replaced, such as the old generic syndicate armor in favor of the new suits they now boast! <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game The more reworked factions, the merrier!!!! <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: PositiveEntropy add The New Gorlex Republic's Second Battlegroup Fleet Now Boasts New Uniforms! /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 13, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
May 19, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request HELLO HELLO EVERYONE, IT'S THAT TIME OF THE YEAR AGAIN! ANOTHER FACTION REWORK LET'S GOOOO WOOOOO YEAH WOOOOO! ON THE MENU TODAY: THE NEW GORLEX REPUBLIC! ![image](https://github.com/shiptest-ss13/Shiptest/assets/77556824/b7790168-483a-4d69-9566-d13880d423de) This PR updates ALL the visuals of our favorite boys in beige. Sadly this does not include new ships, nor does this include new guns. You're gonna have to wait on that for now. This PR adds three new roles that are currently not in an NGR ship (the Hyena), which are: - The Operative (think of it like the Enforcer) - The Medical Doctor - The Lieutenant (Second-In-Command role) The Junior Agent role has now been renamed to Initiate. Any new equipment analogous to old equipment in the Hyena has been fully replaced, such as the old generic syndicate armor in favor of the new suits they now boast! <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game The more reworked factions, the merrier!!!! <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: PositiveEntropy add The New Gorlex Republic's Second Battlegroup Fleet Now Boasts New Uniforms! /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code change
Watch something violently break.
DME Edit
Map Change
Tile placing is hard. Thank you for your service.
Sprites
A bikeshed full of soulless bikes.
Test Merge Candidate
You do it for free.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
HELLO HELLO EVERYONE, IT'S THAT TIME OF THE YEAR AGAIN! ANOTHER FACTION REWORK LET'S GOOOO WOOOOO YEAH WOOOOO!
ON THE MENU TODAY: THE NEW GORLEX REPUBLIC!
This PR updates ALL the visuals of our favorite boys in beige. Sadly this does not include new ships, nor does this include new guns. You're gonna have to wait on that for now. This PR adds three new roles that are currently not in an NGR ship (the Hyena), which are:
The Junior Agent role has now been renamed to Initiate.
Any new equipment analogous to old equipment in the Hyena has been fully replaced, such as the old generic syndicate armor in favor of the new suits they now boast!
Why It's Good For The Game
The more reworked factions, the merrier!!!!
Changelog
🆑 PositiveEntropy
add The New Gorlex Republic's Second Battlegroup Fleet Now Boasts New Uniforms!
/:cl: