Minor fixes and improvement to Flavor Text #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yippie! |
|
Big if true |
Chops flavor text down from 4096 to 1024 Brought back stripped multiline after I realized that I should just have checked what the proc actually did And some less hardcoding to prevent issues
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shiptest-server
pushed a commit
that referenced
this pull request
Jun 2, 2024
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Improves and fixes issues where flavor text would sanitize certain characters and refuse new lines while also giving new looks to the flavor text page. Bits of codes for the popup was taken from MapleStation but I can't find the specific PR for it. Flavor text's length was also chopped from a whooping 4096 to 1024 for the sake of keeping it lag free, it should still allow you to make a pretty robust flavor text and it shouldn't really impact anyone as the average flavor text length I've seen on a round was around 362 characters, with the highest being 645 characters.  Additionally changes the text a bit on the flavor text's edit popup so it leads to less confusion. I'm intending to do a full refactor for flavor text itself and hopefully make use of TGUI but this might take quite a bit and I can't really make any guarantees, so hopefully this helps for now. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> Flavor text has been buggy and limiting for quite a while, while this PR doesn't solve many code shenanigans it should at least help people describe how their characters a lot better and with less wall of texts. As for the text changes; I believe this might make more sense and hopefully lead to less confusion that I'd see some have when it comes to flavor text. :cl: Hardly add: Added some style to the flavor text popup fix: Fixed flavor text not accepting certain characters or new lines tweak: Changed up Flavor Text editing text a bit tweak: Flavor text's max length has been chopped from 4096 to 1024 /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: FalloutFalcon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Improves and fixes issues where flavor text would sanitize certain characters and refuse new lines while also giving new looks to the flavor text page. Bits of codes for the popup was taken from MapleStation but I can't find the specific PR for it.
Flavor text's length was also chopped from a whooping 4096 to 1024 for the sake of keeping it lag free, it should still allow you to make a pretty robust flavor text and it shouldn't really impact anyone as the average flavor text length I've seen on a round was around 362 characters, with the highest being 645 characters.
Additionally changes the text a bit on the flavor text's edit popup so it leads to less confusion.
I'm intending to do a full refactor for flavor text itself and hopefully make use of TGUI but this might take quite a bit and I can't really make any guarantees, so hopefully this helps for now.
Why It's Good For The Game
Flavor text has been buggy and limiting for quite a while, while this PR doesn't solve many code shenanigans it should at least help people describe how their characters a lot better and with less wall of texts.
As for the text changes; I believe this might make more sense and hopefully lead to less confusion that I'd see some have when it comes to flavor text.
Changelog
🆑 Hardly
add: Added some style to the flavor text popup
fix: Fixed flavor text not accepting certain characters or new lines
tweak: Changed up Flavor Text editing text a bit
tweak: Flavor text's max length has been chopped from 4096 to 1024
/:cl: