Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tech shells to the outpost market, recipe rebalance and buffs #2958

Merged
merged 12 commits into from
Jun 12, 2024

Conversation

Gristlebee
Copy link
Contributor

@Gristlebee Gristlebee commented May 5, 2024

About The Pull Request

Adds unloaded techshells to the outpost market, 7 shells for 175 credits.

Recipe changes

  • Scatter Laser: 1 Adv Capacitor, 1 Adv Microlaser -> 1 Capacitor, 3 Microlaser, 1 power cell, 5u lithium
  • Pulse Slug: 2 Adv Capacitor, 1 Ultra Microlaser -> 3 Capacitor, 1 Microlaser, 1 power cell, 5u lithium
  • Scatter Ion: 1 Ansible Crystal, 1 Ultra Microlaser -> 2 Capacitor, 2 Microlaser, 1 scanning module, 5u iron, 5u uranium
  • Dragonsbreath : 5u phosphorous -> 10u phosphorous

Changes the scatter ion desc to reflect the new recipe.

Ammo changes

Scatter laser and ion now fires 8 pellets, instead of 4, variance is 25 from 35
Dragonsbreath now fires 8 pellets instead of 4, deals 8 damage up from 5, variance is 45 from 35.

Why It's Good For The Game

These techshells were pretty underwhelming for what they were, and pretty heavily gated behind RND. For all the effort of researching and printing techshells with scatter lasers for example, you'd get a 60 damage shell on par with an improvised buckshot you made with scrap.

These changes should make them more comparable with standard ammunition and not so reliant on needing RND. I think techshells are pretty interesting and adds a versatile combat option.

Changelog

🆑
add: Techshell box
add: Techshells to the outpost market for 175 credits
tweak: Scatter ion description
balance: Techshell recipes no longer require higher tier stock parts, adjusts scatter laser, scatter ion, dragonsbreath and pulse slug recipes
balance: Buffs scatter lasers, scatter ion and dragonsbreath
/:cl:

@Gristlebee Gristlebee requested a review from a team as a code owner May 5, 2024 04:58
@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels May 5, 2024
@thgvr
Copy link
Member

thgvr commented May 5, 2024

personally i think tech shells are lame and would rather see them removed

@Imaginos16
Copy link
Member

Imaginos16 commented May 5, 2024

Personally this is a goated as hell PR and it gives tech shells a proper niche now instead of it being gatekept by RND shenanigans. If only the other RND-gated Roumain guns could follow suit.

@Imaginos16
Copy link
Member

If only the other RND-gated Roumain guns could follow suit.

Actually this is quite the idea for a PR now that I think about it, time to cook.

@thgvr
Copy link
Member

thgvr commented May 5, 2024

I also don't really want to see pulse slugs taking down walls as well as the super turf fires

@Gristlebee
Copy link
Contributor Author

I also don't really want to see pulse slugs taking down walls as well as the super turf fires

Pulse shots dont break walls anymore after #2315. The turf fires from the pulse slug is also handled by a proc, so I can tone down it's strength if that's an issue.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label May 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed Merge Conflict Use Git Hooks, you're welcome. DME Edit labels May 21, 2024
code/modules/cargo/packs/ammo.dm Outdated Show resolved Hide resolved
@FalloutFalcon FalloutFalcon added the Test Merge Required They'll have to do it for free. label May 28, 2024
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill need thgvrs approval on this one since they had thoughts about tech shells but i support it

@FalloutFalcon FalloutFalcon added Test Merged They've done it for free. Balance/Rebalance Makes powergaming easier in expected ways, or easier in unexpected ways. and removed Test Merge Required They'll have to do it for free. labels Jun 8, 2024
@Imaginos16
Copy link
Member

Thgvr said they didn't particularly care so I'll get this merged. Yippie!

@Imaginos16 Imaginos16 added this pull request to the merge queue Jun 12, 2024
Merged via the queue into shiptest-ss13:master with commit 4626817 Jun 12, 2024
14 checks passed
@Gristlebee Gristlebee deleted the techshells branch August 18, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance/Rebalance Makes powergaming easier in expected ways, or easier in unexpected ways. Code change Watch something violently break. Sprites A bikeshed full of soulless bikes. Test Merged They've done it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants