Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-themes the Delta to N+S Logistics #2967

Merged
merged 5 commits into from
May 20, 2024

Conversation

Apogee-dev
Copy link
Contributor

About The Pull Request

delta-ns
n-s_decals

Updates the delta (decal swaps and outfit changes) to be properly associated with N+S Logistics rather than just Nanotrasen, and adds N+S floor decals and signs.

Why It's Good For The Game

New lore representation is good.

Changelog

🆑
tweak: Made the Delta more obviously affiliated with N+S Logistics
/:cl:

@Apogee-dev Apogee-dev requested review from a team as code owners May 8, 2024 06:22
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels May 8, 2024
Apogee-dev added 2 commits May 7, 2024 23:30
god I can't wait for faction defined in ship configs
@Apogee-dev Apogee-dev added the Test Merge Required They'll have to do it for free. label May 8, 2024
goober3
goober3 previously requested changes May 8, 2024
Copy link
Member

@goober3 goober3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goes hard.
the central hallway and cryo room needs a light switch, this is good otherwise.

futureproofing for plastic flap nerf
@Apogee-dev
Copy link
Contributor Author

addressed review and futureproofed a bit for plastic flaps nerfs. Should be good to go now

Copy link
Member

@Imaginos16 Imaginos16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya this looks fine who cares.

@Imaginos16 Imaginos16 added this pull request to the merge queue May 20, 2024
Merged via the queue into shiptest-ss13:master with commit 046f512 May 20, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request May 25, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![delta-ns](https://github.com/shiptest-ss13/Shiptest/assets/60533805/5d25128b-4603-46ea-b498-22551d9d9555)

![n-s_decals](https://github.com/shiptest-ss13/Shiptest/assets/60533805/62d6149f-9d34-4a09-abf3-f2b35f5b0a6f)

Updates the delta (decal swaps and outfit changes) to be properly
associated with N+S Logistics rather than just Nanotrasen, and adds N+S
floor decals and signs.

## Why It's Good For The Game

New lore representation is good.

## Changelog

:cl:
tweak: Made the Delta more obviously affiliated with N+S Logistics
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants