Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes plasma thruster acceleration #2980

Merged
merged 4 commits into from
May 31, 2024

Conversation

SomeguyManperson
Copy link
Contributor

About The Pull Request

If you burned the expected amount of fuel you got full thrust regardless of throttle

Why It's Good For The Game

Changelog

🆑
fix: fueled thruster throttling now works right
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label May 11, 2024
@Erring
Copy link

Erring commented May 11, 2024

image
I checked this bug with plasma thrust, you still can abuse 0% throttle max thrust bug and I can't find code for plasma thrust's percentage thrust. There is a bug with plasma engines having full trust at 0 thrust. Btw, fuel consumption previously seems to be always maxed out.

@SomeguyManperson
Copy link
Contributor Author

SomeguyManperson commented May 11, 2024

Testing this locally it has worked, fuel expense isn't impacted and worked as intended, it's just the thrust only cared if it successfully burnt that amount of fuel and forgot to care about throttle % (so if you had your plasmas at 1% they'd burn 1% of fuel and say "yeah100% of that 1% burnt" and go at 100% speed)

@Erring
Copy link

Erring commented May 12, 2024

Testing this locally it has worked, fuel expense isn't impacted and worked as intended, it's just the thrust only cared if it successfully burnt that amount of fuel and forgot to care about throttle % (so if you had your plasmas at 1% they'd burn 1% of fuel and say "yeah100% of that 1% burnt" and go at 100% speed)

Sorry, I forgot to tell you, but this bug exists even in your branch. That's where I sent the screenshot with the bug from. Here the gimmick of it is that it burns 0 percent plasma and gets full trust. Perhaps the multiplication by throttle change is lost.

@thgvr thgvr added this pull request to the merge queue May 13, 2024
@SomeguyManperson
Copy link
Contributor Author

When testing this myself it has worked fine

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@rye-rice rye-rice added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@FalloutFalcon FalloutFalcon added this pull request to the merge queue May 31, 2024
Merged via the queue into shiptest-ss13:master with commit c70a086 May 31, 2024
14 checks passed
@SomeguyManperson SomeguyManperson deleted the patch-10 branch June 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants