Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports Bodycameras from Fulp #2982

Closed
wants to merge 14 commits into from
Closed

Conversation

Zevotech
Copy link
Contributor

@Zevotech Zevotech commented May 11, 2024

About The Pull Request

Ports a player-attachable camera that can be viewed on security camera consoles from fulpstation with some adjustments and fixes to make it work on our codebase.
Also ports most of tgstation/tgstation#52767 to fix movable cameras being a black screen.

The body camera is attached to a jumpsuit, and enabled using an ID. The jumpsuit must be worn for the camera to be active. The body camera can be used on a security camera console to connect it to the network of the console.

They can be found on ships that have security camera consoles or in the security section of cargo for 2000 credits per box.

TODO:

Make modcomps connectable to security camera console networks and maybe start with the security camera network of the area they spawn in

  • Possibly get better sprites for the body cameras (Sort of half done. May get one from a better spriter)
  • Add body cameras to maps that would have them
    Maps with body cameras: Mudskipper, Riggs, Shetland, Talos, Osprey, Ranger, Crying Sun, Chronicle, Li Tieguai, Komodo, Hyena

Why It's Good For The Game

You can now monitor individuals from afar using a security camera console! Good for mining vessels and military vessels, as well as any vessel with a dedicated, well-stocked security force. Great for coordination!

Potential changes:

  1. May try to find away to make them armor-mounted without the issues that come with them being stored in the armor inventory.
  2. Due to modcomps not connecting to ship camera networks, they don't work with SecureEye. May look into a potential fix but otherwise I want to avoid touching modcomp code.
  3. Needs better sprites, possibly an icon for the jumpsuit to indicate it has a bodycam attached.

Changelog

🆑
add: adds Bodycameras, ported from fulpstation
add: adds body cameras to the Mudskipper, Riggs, Shetland, Talos, Osprey, Ranger, Crying Sun, Chronicle, Li Tieguai, Komodo, and Hyena
fix: Ports a fix from tg that fixed movable cameras being a black screen
/:cl:

@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels May 11, 2024
@Sun-Soaked
Copy link
Member

aegis security turn off bodycam macro

@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Jun 11, 2024
@Zevotech Zevotech marked this pull request as ready for review June 11, 2024 16:47
@Zevotech Zevotech requested review from a team as code owners June 11, 2024 16:47
Comment on lines +1 to +3
/obj/item/clothing/under/Initialize(mapload)
. = ..()
AddComponent(/datum/component/bodycamera_holder)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont like this being here, it should be in the real Init.

code/game/machinery/computer/camera.dm Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jun 24, 2024
@Zevotech Zevotech marked this pull request as draft July 8, 2024 10:21
@rye-rice
Copy link
Member

rye-rice commented Aug 6, 2024

sowwy, nwo prwogwess iwn mwonths, rweopwen wwen wrorking on iwt agwian

@rye-rice rye-rice closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Merge Conflict Use Git Hooks, you're welcome. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants