-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports Bodycameras from Fulp #2982
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DME Edit
Sprites
A bikeshed full of soulless bikes.
Code change
Watch something violently break.
labels
May 11, 2024
aegis security turn off bodycam macro |
github-actions
bot
added
the
Map Change
Tile placing is hard. Thank you for your service.
label
Jun 11, 2024
FalloutFalcon
requested changes
Jun 15, 2024
Comment on lines
+1
to
+3
/obj/item/clothing/under/Initialize(mapload) | ||
. = ..() | ||
AddComponent(/datum/component/bodycamera_holder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont like this being here, it should be in the real Init.
Co-authored-by: FalloutFalcon <[email protected]> Signed-off-by: zevo <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
sowwy, nwo prwogwess iwn mwonths, rweopwen wwen wrorking on iwt agwian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code change
Watch something violently break.
DME Edit
Map Change
Tile placing is hard. Thank you for your service.
Merge Conflict
Use Git Hooks, you're welcome.
Sprites
A bikeshed full of soulless bikes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports a player-attachable camera that can be viewed on security camera consoles from fulpstation with some adjustments and fixes to make it work on our codebase.
Also ports most of tgstation/tgstation#52767 to fix movable cameras being a black screen.
The body camera is attached to a jumpsuit, and enabled using an ID. The jumpsuit must be worn for the camera to be active. The body camera can be used on a security camera console to connect it to the network of the console.
They can be found on ships that have security camera consoles or in the security section of cargo for 2000 credits per box.
TODO:
Make modcomps connectable to security camera console networks and maybe start with the security camera network of the area they spawn inMaps with body cameras: Mudskipper, Riggs, Shetland, Talos, Osprey, Ranger, Crying Sun, Chronicle, Li Tieguai, Komodo, Hyena
Why It's Good For The Game
You can now monitor individuals from afar using a security camera console! Good for mining vessels and military vessels, as well as any vessel with a dedicated, well-stocked security force. Great for coordination!
Potential changes:
Changelog
🆑
add: adds Bodycameras, ported from fulpstation
add: adds body cameras to the Mudskipper, Riggs, Shetland, Talos, Osprey, Ranger, Crying Sun, Chronicle, Li Tieguai, Komodo, and Hyena
fix: Ports a fix from tg that fixed movable cameras being a black screen
/:cl: