Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.45-70 Specialty Ammo #2991

Merged

Conversation

generalthrax
Copy link
Contributor

@generalthrax generalthrax commented May 14, 2024

About The Pull Request

Adds .45-70 Match ammunition to cargo, where it used to only be available through R&D.

Why It's Good For The Game

I love the Beacon but someone raised the very valid point that with default ammunition it hits just barely harder than slugs out of a shotgun. Giving it some options would allow it to fit its own spot on the market and release more ammo from R&D hell.

Changelog

🆑
add: .45-70 Match ammunition added to cargo
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label May 14, 2024
@rye-rice
Copy link
Member

if youre adding the shoulder holster, can you make it hold ONLY a single normal sized pistol/revolver?

@generalthrax
Copy link
Contributor Author

if youre adding the shoulder holster, can you make it hold ONLY a single normal sized pistol/revolver?

I do not know how but I will try

@generalthrax
Copy link
Contributor Author

I'm stumped so I'm just gonna do it in a separate PR when I'm not lazy

@generalthrax generalthrax changed the title .45-70 Specialty Ammo & Shoulder Holster .45-70 Specialty Ammo May 14, 2024
@Apogee-dev
Copy link
Contributor

Apogee-dev commented May 15, 2024

I'm going to throw a veto out on hollow point. Yeah, it's fine on the Beacon, but on the Ashhand- which will in fact be rarely available, once we get it in as loot here and there- it turns into a very rapid two-tap without the range falloff and spread of buckshot, which is the only other readily available cartridge capable of killing in two hits right now- everything else takes 3-5. Match is fine.

@generalthrax
Copy link
Contributor Author

generalthrax commented May 15, 2024

I'm going to throw a veto out on hollow point. Yeah, it's fine on the Beacon, but on the Ashhand- which will in fact be rarely available, once we get it in as loot here and there- it turns into a very rapid two-tap without the range falloff and spread of buckshot, which is the only other readily available cartridge capable of killing in two hits right now- everything else takes 3-5. Match is fine.

I was under the impression that the Ashhand would be for SRM ERT only (to never see the light of day) from imaginos's pr. If Hollow Point is getting ruled out for something that's unlikely to be in game for months (possibly ever) I don't quite understand.

@Apogee-dev
Copy link
Contributor

I'm going to throw a veto out on hollow point. Yeah, it's fine on the Beacon, but on the Ashhand- which will in fact be rarely available, once we get it in as loot here and there- it turns into a very rapid two-tap without the range falloff and spread of buckshot, which is the only other readily available cartridge capable of killing in two hits right now- everything else takes 3-5. Match is fine.

I was under the impression that the Ashhand would be for SRM ERT only (to never see the light of day) from imaginos's pr. If Hollow Point is getting ruled out for something that's unlikely to be in game for months (possibly ever) I don't quite understand.

Ashhand’s slated for SRM ERTs and ruin loot. Hopefully pretty soon on the loot part. I’d rather just not put hollow point in now than have to remove it again in maybe a month.

@generalthrax
Copy link
Contributor Author

generalthrax commented May 15, 2024

I understand that Ashhand with hollow points is ridiculous (against unarmoured targets, two shots to crit), but against targets you're more likely to face (the basic sec complement with an armour vest and helmet), they're significantly more gimmicky in that you have to cycle targets on limbs if you want to capitalize and not do below average .45-70 damage. I can't see players specifically seeking out the Rare Revolver to get the specialty ammo hollow points so they can dome unarmoured indies (rarer than you'd think) in two shots instead of three.

I want them in for the Beacon, which they'd be used for 99% of the time and, as you said, would be fine. If you really don't want them, is there anything I can muck around with here to get them in so they'd be able to work without the problematic point of the Ashhand?

@Apogee-dev
Copy link
Contributor

Apogee-dev commented May 15, 2024

I don’t want to see .45-70 HP nerfed either, honestly. When I coded it, like .45-70 explosive, it was meant to be a high powered option (even moreso than standard .45-70) for ERTs and the like. I think the simple fact of the matter is that the Beacon should never really be competing with slug shotguns. It’s a single shot break action longarm firing a large bore pistol cartridge- That’s never going to stack up against anything with similar or better stopping power and a larger magazine, and I really don’t think it should.

Honestly, I’m very wary of power creep thanks to the ever increasing accessibility of guns and ammo in cargo to stand in for reduced RnD, without the tempering factor of a reputation system or anything like that (which RnD did have in the form of having to grind research points, having a tech tree, and having restricted lathes, for what little credit that earns it. With RnD at least it was only combat ships with easy access to specialized ammo types). That’s more of a big-picture complaint though

@generalthrax
Copy link
Contributor Author

Fair. But I do really hope the reputation system isn't on the backburner, because its only going to get worse from here. One sec

@Apogee-dev
Copy link
Contributor

Also ngl we should think about adding some other .45-70, .357, and .44 Short (whenever that gets added in the first place) variants to the game one of these days. .38’s weird cartridge variants are tons of fun.

Copy link
Member

@Sun-Soaked Sun-Soaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@Sun-Soaked Sun-Soaked added this pull request to the merge queue Jun 2, 2024
Merged via the queue into shiptest-ss13:master with commit bac506f Jun 2, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
Adds .45-70 Match ammunition to cargo, where it used to only be
available through R&D.

I love the Beacon but someone raised the very valid point that with
default ammunition it hits just barely harder than slugs out of a
shotgun. Giving it some options would allow it to fit its own spot on
the market and release more ammo from R&D hell.

:cl:
add: .45-70 Match ammunition added to cargo
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants