Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a salve that allows elzuose to change color #2995

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

Zevotech
Copy link
Contributor

About The Pull Request

To be merged after #2993.
Adds a Kalixcian beauty product that allows Elzuose to (temporarily (for the duration of the round or until used again)) change their glow color. Available in the loadout next to hair dye.

elzurecolor.mp4

Why It's Good For The Game

People wanted to keep the ability to change the glow color of an elzuose using an item. Fits better than just using a multitool without the potential for grief/shenanigans. Lore approved too!

Changelog

🆑
add: Adds the Elzuose color salve, a product that allows Elzuose to change their glow color upon application.
/:cl:

@Zevotech Zevotech requested a review from a team as a code owner May 15, 2024 19:40
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels May 15, 2024
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first sprite

@FalloutFalcon FalloutFalcon added the Feature REALLY causes more bugs in the future that we won't know about. label May 24, 2024
@FalloutFalcon
Copy link
Member

honestly a FIRE first sprite.

@tiramisuapimancer
Copy link
Contributor

I don't really understand the point of changing Elzu recolorability to a bespoke item when the multi tool allowing one to retune frequency was already a thing.

@thgvr
Copy link
Member

thgvr commented May 25, 2024

"retune frequency" doesn't make sense here, they are not made of pure energy or whatever and are organic

@tiramisuapimancer
Copy link
Contributor

they don't need to be, the color of an elzu isn't a pigment, it's the color of the light their electricity emits

Copy link
Member

@Sun-Soaked Sun-Soaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Sun-Soaked Sun-Soaked added this pull request to the merge queue Jun 2, 2024
Merged via the queue into shiptest-ss13:master with commit 74238eb Jun 2, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

To be merged after shiptest-ss13#2993.
Adds a Kalixcian beauty product that allows Elzuose to (temporarily (for
the duration of the round or until used again)) change their glow color.
Available in the loadout next to hair dye.

https://github.com/shiptest-ss13/Shiptest/assets/95449138/01060ea1-4b6b-490f-9bf2-83b69cf7efd7

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

People wanted to keep the ability to change the glow color of an elzuose
using an item. Fits better than just using a multitool without the
potential for grief/shenanigans. Lore approved too!
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
add: Adds the Elzuose color salve, a product that allows Elzuose to
change their glow color upon application.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Feature REALLY causes more bugs in the future that we won't know about. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants