Fixes create and destory failure due to missing physiology #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiptest-server
pushed a commit
that referenced
this pull request
Jun 2, 2024
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jun 22, 2024
…ss13#2999) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Sometimes during unit tests (prob shouldn't happen in the first place) a human will get created and have electrocute act called by a tesla anomaly which causes a fail because it looks for a shock resist in physiology which doesn't yet exist. If humans are shocked during init and it does not have its physiology yet it now returns It may be better to just have an if physiology for fetching the physiology siemens but if its missing its physiology its prob missing other thing needed like generating organs or dna <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> im tired of half my prs failing from this <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: fix: fixed create and destroy test fail /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Sometimes during unit tests (prob shouldn't happen in the first place) a human will get created and have electrocute act called by a tesla anomaly which causes a fail because it looks for a shock resist in physiology which doesn't yet exist.
If humans are shocked during init and it does not have its physiology yet it now returns
It may be better to just have an if physiology for fetching the physiology siemens but if its missing its physiology its prob missing other thing needed like generating organs or dna
Why It's Good For The Game
im tired of half my prs failing from this
Changelog
🆑
fix: fixed create and destroy test fail
/:cl: