Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes comms consoles from ships and ruins #3000

Merged
merged 6 commits into from
May 24, 2024

Conversation

FalloutFalcon
Copy link
Member

About The Pull Request

replaces all ruin and ship comms consoles with frames

Why It's Good For The Game

Ships should not have access to some of these global things
image

Changelog

🆑
del: Removed comms consoles from ruins and ships
/:cl:

@FalloutFalcon FalloutFalcon requested a review from a team as a code owner May 18, 2024 02:35
@FalloutFalcon FalloutFalcon changed the title Comms console Removes comms consoles from ships and ruins May 18, 2024
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label May 18, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label May 20, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label May 20, 2024
@Hlscientist
Copy link

hehe alert go brrrrrrrr

Copy link
Contributor

@Zevotech Zevotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as a stopgap until comms consoles eventually get a rework (ten thousand years later)

@Zevotech Zevotech added this pull request to the merge queue May 24, 2024
Merged via the queue into shiptest-ss13:master with commit 014139b May 24, 2024
14 checks passed
@FalloutFalcon FalloutFalcon deleted the comms-console branch May 24, 2024 07:11
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request May 25, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
replaces all ruin and ship comms consoles with frames
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Ships should not have access to some of these global things

![image](https://github.com/shiptest-ss13/Shiptest/assets/86381784/38354c7b-c902-441a-b814-d86eb1e6630a)

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
del: Removed comms consoles from ruins and ships
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants