Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holopad Caller History #3005

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

Gristlebee
Copy link
Contributor

About The Pull Request

Holopads now show the location of the last holopad that called them on examine.

Why It's Good For The Game

While having to shamefully ask over wideband to have someone call again after you missed their call is funny, knowing where to callback if you miss someone should help streamline ship to ship communication and improve quality of life.

Changelog

🆑
add: Holopads now display the location of the last holopad that called them on examine.
code: Span macros for hologram.dm
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label May 19, 2024
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good QOL

code/game/machinery/hologram.dm Outdated Show resolved Hide resolved
Co-authored-by: FalloutFalcon <[email protected]>
Signed-off-by: Gristlebee <[email protected]>
@FalloutFalcon FalloutFalcon added this pull request to the merge queue May 27, 2024
Merged via the queue into shiptest-ss13:master with commit 79d4142 May 28, 2024
14 checks passed
@Gristlebee Gristlebee deleted the caller_history branch May 29, 2024 01:00
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jun 1, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Holopads now show the location of the last holopad that called them on
examine.

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

While having to shamefully ask over wideband to have someone call again
after you missed their call is funny, knowing where to callback if you
miss someone should help streamline ship to ship communication and
improve quality of life.

## Changelog

:cl:
add: Holopads now display the location of the last holopad that called
them on examine.
code: Span macros for hologram.dm
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Gristlebee <[email protected]>
Co-authored-by: FalloutFalcon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants