Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Drinkening #3019

Merged
merged 47 commits into from
Jun 17, 2024
Merged

The Drinkening #3019

merged 47 commits into from
Jun 17, 2024

Conversation

GenericDM
Copy link
Member

About The Pull Request

This pull request contains an incredible number of changes to item names and descriptions regarding everything drinkable.
This has been a long time coming, and was put off for quite a while due to my own procrastination.

This is almost certainly going to have mapping errors, but I'm not checking them all myself. I'll let the tests figure it out for me.

  • Space Mountain Wind changed to Comet Trail
  • Dr. Gibb changed to Tadrixx
  • Starkist changed to Lunapunch
  • PWR Game changed to Pacfuel
  • Lemon Lime changed to Orange Soda
  • Nuka Cola removed
  • Thirteen Loko changed to Vimukti
  • Fetching Fizz removed
  • Manhattan Project removed
  • Narsour removed
  • Monkey Energy changed to Xeno Energy
  • unbranded water bottle changed to Ryuunosuke Reserve
  • space beer changed to Bizircan Brewery GDM
  • Magm-Ale changed to RHIMBASA TAP
  • Space Cola reflavored
  • Tonic water reflavored
  • Soda water reflavored
  • Grey Bull changed to Crosstalk
  • E-Fuel removed
  • Canned Air reflavored
  • Molten Bubbles reflavored and refactored
  • Plasma Fizz reflavored and refactored
  • Gin reflavored
  • Whiskey reflavored
  • Vodka reflavored
  • Tequila reflavored
  • Patron reflavored
  • Rum reflavored
  • Holy water reflavored
  • Vermouth reflavored
  • Kahlua reflavored
  • Goldschlager reflavored
  • Cognac reflavored
  • Wine reflavored
  • Absinthe reflavored, randomization removed
  • Premium Absinthe reflavored
  • Lizard Wine reflavored, again
  • Hard Cider reflavored
  • Amaretto reflavored
  • Grappa reflavored
  • Sake reflavored, as well as random reskins
  • Fernet reflavored
  • Orange Juice reflavored
  • Cream reflavored
  • Tomato Juice reflavored
  • Lime Juice reflavored
  • Grenadine reflavored
  • Applejack reflavored
  • Champagne reflavored
  • Blazaam reflavored to Hyperspace Highball(I've never even heard of this?)
  • Trappist Bleu reflavored
  • Hooch reflavored
  • Moonshine reflavored
  • Creme de Coconut reflavored
  • Cuba Libre reflavored to Frontier Libre
  • White Russian reflavored to White Gezenan
  • Irish Cream reflavored to Zohil Cream
  • Manly Dorf reflavored to Shortstop
  • B-52 reflavored to AM-G
  • Irish Coffee reflavored to Gezenan Coffee
  • Black Russian reflavored to Black Rachnid
  • Manhattan reflavored to Twelve Crossings
  • Red Mead reflavored to Drop-pod
  • Allies Cocktail reflavored to Canton Cocktail
  • Acid Spit reflavored to Cracked Moon
  • Amasec reflavored to Ren Kirsi
  • Irish Car Bomb reflavored to Lightspeed
  • Syndicate Bomb reflavored to Gorlex Surprise
  • Hivemind Eraser reflavored to Hivemind
  • Erika Surprise reflavored to Terraformer Surprise
  • Driest Martini reflavored to Saltflat
  • Banana Honk reflavored to Creamtruck
  • Silencer reflavored to Choker
  • Hippie's Delight reflavored to Between the Mandibles
  • Alexander reflavored to Ash-Shield
  • Amaretto Alexander reflavored to Happy Huntsman
  • Sidecar reflavored to Bridge Bunny
  • Kamikaze reflavored to Mothball
  • Moscow Mule reflavored to Gorlex Gator
  • Fernet Cola reflavored to Weldline
  • Branca Menta reflavored to Mirage
  • Bug Spray reflavored to Stunball
  • Jack Rose reflavored to Jackalope
  • Duplex reflavored to North-South
  • Mauna Loa reflavored to Inner Fire
  • Mudder's Milk reflavored to Miner's Milk
  • Freezer Burn reflavored to Hullbreach
  • Archmagus' brew removed
  • Cogchamp removed
  • Shambler's Juice reflavored to Shoal Punch
  • Gibb Floats reflavored to Tadrixx Float

Vending machines reflavored

Good lord I hope I didn't miss anything.

Immense thanks to Stripes for doing all of the writing for this, with some help from our lore team. We miss you. I hope you're doing well.

Why It's Good For The Game

Distances us from TG, and helps build our setting.

Changelog

🆑 @thestripes, @meemofcourse , @GenericDM
tweak: reflavors nearly every drink ingame
/:cl:

thestripes and others added 30 commits February 7, 2024 14:04
…rs Monkey Energy to Xeno-Energy, dutch hot coco to Solar's Best Hot Cocoa, robust coffee to Solar's Best black coffee, changes the recipes that call for Dr. Gibb to instead require Tradixx. please god dont fuck this up
…rent reflavorings, and adds reagents for Molten Bubbles and Plasma Fizz.
…zer joke instead, this might be orphaning the lemon-lime soda? if so I can just Make Something for it
@thgvr
Copy link
Member

thgvr commented Jun 1, 2024

No updatepaths? Its over

@GenericDM GenericDM requested a review from a team as a code owner June 2, 2024 20:14
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jun 2, 2024
@GenericDM GenericDM requested a review from thgvr June 6, 2024 20:23
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jun 9, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jun 10, 2024
@thgvr
Copy link
Member

thgvr commented Jun 10, 2024

no react andies allowed

@Imaginos16 Imaginos16 added Test Merge Candidate You do it for free. Test Merge Required They'll have to do it for free. labels Jun 12, 2024
@Imaginos16
Copy link
Member

TM requested by PR author.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jun 12, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jun 12, 2024
@thgvr thgvr added this pull request to the merge queue Jun 17, 2024
Merged via the queue into shiptest-ss13:master with commit 6b3d550 Jun 17, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

This pull request contains an incredible number of changes to item names
and descriptions regarding everything drinkable.
This has been a long time coming, and was put off for quite a while due
to my own procrastination.

This is almost certainly going to have mapping errors, but I'm not
checking them all myself. I'll let the tests figure it out for me.

- Space Mountain Wind changed to Comet Trail
- Dr. Gibb changed to Tadrixx
- Starkist changed to Lunapunch
- PWR Game changed to Pacfuel
- Lemon Lime changed to Orange Soda
- Nuka Cola removed
- Thirteen Loko changed to Vimukti
- Fetching Fizz removed
- Manhattan Project removed
- Narsour removed
- Monkey Energy changed to Xeno Energy
- unbranded water bottle changed to Ryuunosuke Reserve
- space beer changed to Bizircan Brewery GDM
- Magm-Ale changed to RHIMBASA TAP
- Space Cola reflavored
- Tonic water reflavored
- Soda water reflavored
- Grey Bull changed to Crosstalk
- E-Fuel removed
- Canned Air reflavored
- Molten Bubbles reflavored and refactored
- Plasma Fizz reflavored and refactored
- Gin reflavored
- Whiskey reflavored
- Vodka reflavored
- Tequila reflavored
- Patron reflavored
- Rum reflavored
- Holy water reflavored
- Vermouth reflavored
- Kahlua reflavored
- Goldschlager reflavored
- Cognac reflavored
- Wine reflavored
- Absinthe reflavored, randomization removed
- Premium Absinthe reflavored
- Lizard Wine reflavored, again
- Hard Cider reflavored
- Amaretto reflavored
- Grappa reflavored
- Sake reflavored, as well as random reskins
- Fernet reflavored
- Orange Juice reflavored
- Cream reflavored
- Tomato Juice reflavored
- Lime Juice reflavored
- Grenadine reflavored
- Applejack reflavored
- Champagne reflavored
- Blazaam reflavored to Hyperspace Highball(I've never even heard of
this?)
- Trappist Bleu reflavored
- Hooch reflavored
- Moonshine reflavored
- Creme de Coconut reflavored
- Cuba Libre reflavored to Frontier Libre
- White Russian reflavored to White Gezenan
- Irish Cream reflavored to Zohil Cream
- Manly Dorf reflavored to Shortstop
- B-52 reflavored to AM-G
- Irish Coffee reflavored to Gezenan Coffee
- Black Russian reflavored to Black Rachnid
- Manhattan reflavored to Twelve Crossings
- Red Mead reflavored to Drop-pod
- Allies Cocktail reflavored to Canton Cocktail
- Acid Spit reflavored to Cracked Moon
- Amasec reflavored to Ren Kirsi
- Irish Car Bomb reflavored to Lightspeed
- Syndicate Bomb reflavored to Gorlex Surprise
- Hivemind Eraser reflavored to Hivemind
- Erika Surprise reflavored to Terraformer Surprise
- Driest Martini reflavored to Saltflat
- Banana Honk reflavored to Creamtruck
- Silencer reflavored to Choker
- Hippie's Delight reflavored to Between the Mandibles
- Alexander reflavored to Ash-Shield
- Amaretto Alexander reflavored to Happy Huntsman
- Sidecar reflavored to Bridge Bunny
- Kamikaze reflavored to Mothball
- Moscow Mule reflavored to Gorlex Gator
- Fernet Cola reflavored to Weldline
- Branca Menta reflavored to Mirage
- Bug Spray reflavored to Stunball
- Jack Rose reflavored to Jackalope
- Duplex reflavored to North-South
- Mauna Loa reflavored to Inner Fire
- Mudder's Milk reflavored to Miner's Milk
- Freezer Burn reflavored to Hullbreach
- Archmagus' brew removed
- Cogchamp removed
- Shambler's Juice reflavored to Shoal Punch
- Gibb Floats reflavored to Tadrixx Float

Vending machines reflavored

Good lord I hope I didn't miss anything.

Immense thanks to Stripes for doing all of the writing for this, with
some help from our lore team. We miss you. I hope you're doing well.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Distances us from TG, and helps build our setting.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl: @thestripes, @meemofcourse , @GenericDM
tweak: reflavors nearly every drink ingame
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Stripes <[email protected]>
Co-authored-by: meemofcourse <[email protected]>
Co-authored-by: Theos <[email protected]>
@Hlscientist
Copy link

image

@Hlscientist
Copy link

Im like, 99% sure tequila isnt in the vendors, neither is absethine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Test Merge Candidate You do it for free. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants