Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP More Kepori Sounds #3034

Closed
wants to merge 1 commit into from
Closed

Conversation

Anticept
Copy link
Contributor

@Anticept Anticept commented May 29, 2024

About The Pull Request

Adding more emote sounds for our fav little feathered raptors. DO NOT MERGE (but will be kept in a state safe for TM). More to come. This DRAFT PR is up to make it easier to see progress and get feedback as more is added.

Oh and volume adjusted on the two kepori sounds we do have so they arent so ear destroying.

Also, the emote system is really annoying. Mothroaches were supposed to be able to chitter like moths but as coded, it would never have worked. While attempting to fix it, it created more problems than it solved, so it's been pulled for something that will basically never be seen or cared about anyways.

Also, emote cooldown increased to 2 seconds, looking for feedback. It's meant to not eliminate silliness with emote sounds, but tone down how loud it gets.

Chitter was originally just meant to be a moth emote, now the code name is generalized.

Why It's Good For The Game

Kepori emotes? What more to say?

Changelog

🆑 Anticept, dorkydorker
add: More Kepori emote sounds!
changed: Repeating emote cooldown increased to 2s.
changed: Tweaked kepori whistle and click to not be so loud.
remove: mothroach never had a working chitter and it's causing issues trying to make it work. Removed.
/:cl:

@github-actions github-actions bot added Sound USSR Anthem 2.66 MB file. Code change Watch something violently break. labels May 29, 2024
@thgvr
Copy link
Member

thgvr commented Jun 1, 2024

Seems you meant to draft this

@thgvr thgvr marked this pull request as draft June 1, 2024 15:55
@Anticept
Copy link
Contributor Author

Anticept commented Jun 1, 2024

Thanks. I realized I have never actually used that feature. We'll have more coming soon.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jun 21, 2024
@Anticept
Copy link
Contributor Author

That's not the end of this, ill reopen later, just its hard to find bird sounds that are fitting for kepori that don't have licensing issues. Still looking!

@Anticept Anticept closed this Aug 27, 2024
@Anticept Anticept deleted the pekori-sounds branch November 2, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Merge Conflict Use Git Hooks, you're welcome. Sound USSR Anthem 2.66 MB file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants