Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more crusher trophy effects #3046

Merged
merged 9 commits into from
Jun 4, 2024

Conversation

FalloutFalcon
Copy link
Member

About The Pull Request

removes crusher trophies relevance from crushers. I didn't fully remove them because they are neat for crafting and.. as trophies
atomization of #2848

Why It's Good For The Game

miner power gamer cruft. Its not really needed when we are trying to balance stuff around guns. Crusher still remains the strongest mostly obtainable melee weapon.

Changelog

🆑
del: Trophies can no longer be used in crushers
/:cl:

@FalloutFalcon FalloutFalcon requested a review from a team as a code owner May 31, 2024 07:11
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Code change Watch something violently break. labels May 31, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jun 2, 2024
@Sun-Soaked
Copy link
Member

Code looks fine, but I'd kinda want a use for trophies that don't have one if you're keeping them

@FalloutFalcon
Copy link
Member Author

Code looks fine, but I'd kinda want a use for trophies that don't have one if you're keeping them

Crafting recipes, Cool little thropies, and i would like to work them into a bounty system at some point

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jun 2, 2024
@Sun-Soaked
Copy link
Member

Code looks fine, but I'd kinda want a use for trophies that don't have one if you're keeping them

Crafting recipes, Cool little thropies, and i would like to work them into a bounty system at some point

there are some that don't currently have a use, though. I wouldn't leave them accessible, especially to players who currently Expect Them to Do A Specific Thing.

@FalloutFalcon
Copy link
Member Author

Code looks fine, but I'd kinda want a use for trophies that don't have one if you're keeping them

Crafting recipes, Cool little thropies, and i would like to work them into a bounty system at some point

there are some that don't currently have a use, though. I wouldn't leave them accessible, especially to players who currently Expect Them to Do A Specific Thing.

hgmmmmmmmm fine.

Copy link
Member

@Sun-Soaked Sun-Soaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@Sun-Soaked Sun-Soaked added this pull request to the merge queue Jun 4, 2024
Merged via the queue into shiptest-ss13:master with commit 9b14e5a Jun 4, 2024
14 checks passed
@FalloutFalcon FalloutFalcon deleted the crusher-cruft branch June 18, 2024 23:34
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

removes crusher trophies relevance from crushers. I didn't fully remove
them because they are neat for crafting and.. as trophies
atomization of shiptest-ss13#2848

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

miner power gamer cruft. Its not really needed when we are trying to
balance stuff around guns. Crusher still remains the strongest mostly
obtainable melee weapon.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
del: Trophies can no longer be used in crushers
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants