Small gun changes #3048
Merged
Small gun changes #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
FalloutFalcon
added
the
Balance/Rebalance
rye-rice
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Please be aware anything with the old gun pallete/ WS era zeta style is intentionally elft untouched as the proto SMG is unlikely to survive a planned NT/SL gun rework, and also be aware that i'm avoiding putting more things under skm_carbine as foldable stocks are meant to be attachments, eg you dont need to do weird subtyping like this.
This approval is for the sprites and shotgun, I'm unsure about the changes i mentioned however.
|
Oh and the TEC-9 has a 0% chance of living post scarborgh PR, be aware of that as well |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
Merge Conflict
FalloutFalcon
requested changes
Jun 18, 2024
FalloutFalcon
approved these changes
Jun 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
FalloutFalcon
approved these changes
Jun 26, 2024
shiptest-server
pushed a commit
that referenced
this pull request
Jun 26, 2024
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jun 30, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Makes the combat shotgun bulky instead of huge, and the compact combat shotgun medium instead of bulky Repaths the saber SMG to be a child of the skm carbine so the stock is able to fold and changes Adds automatic fire to the TEC-9 and makes it normal sized. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> The combat shotgun being huge is a holdover from station based server balance. It being bulky now will make it be able to fit in armor vests. Moves the compact combat shotgun down to normal as a result since it's supposed to be the compact version. The Saber and TEC-9 changes are so they're accurate to their descriptions of having a folding stock and having a fast rate of fire respectively. Ups the TEC-9 to normal sized as a result since having an automatic pistol you can fit in your boot is probably not good. :cl: tweak: Saber SMG stock folds tweak: TEC-9 Pistol is now automatic and normal sized balance: Combat shotgun is now bulky, and the compact combat shotgun is normal. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Jun 30, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Makes the combat shotgun bulky instead of huge, and the compact combat shotgun medium instead of bulky Repaths the saber SMG to be a child of the skm carbine so the stock is able to fold and changes Adds automatic fire to the TEC-9 and makes it normal sized. ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> The combat shotgun being huge is a holdover from station based server balance. It being bulky now will make it be able to fit in armor vests. Moves the compact combat shotgun down to normal as a result since it's supposed to be the compact version. The Saber and TEC-9 changes are so they're accurate to their descriptions of having a folding stock and having a fast rate of fire respectively. Ups the TEC-9 to normal sized as a result since having an automatic pistol you can fit in your boot is probably not good. ## Changelog :cl: tweak: Saber SMG stock folds tweak: TEC-9 Pistol is now automatic and normal sized balance: Combat shotgun is now bulky, and the compact combat shotgun is normal. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes the combat shotgun bulky instead of huge, and the compact combat shotgun medium instead of bulky
Repaths the saber SMG to be a child of the skm carbine so the stock is able to fold and changes
Adds automatic fire to the TEC-9 and makes it normal sized.
Why It's Good For The Game
The combat shotgun being huge is a holdover from station based server balance. It being bulky now will make it be able to fit in armor vests. Moves the compact combat shotgun down to normal as a result since it's supposed to be the compact version.
The Saber and TEC-9 changes are so they're accurate to their descriptions of having a folding stock and having a fast rate of fire respectively. Ups the TEC-9 to normal sized as a result since having an automatic pistol you can fit in your boot is probably not good.
Changelog
🆑
tweak: Saber SMG stock folds
tweak: TEC-9 Pistol is now automatic and normal sized
balance: Combat shotgun is now bulky, and the compact combat shotgun is normal.
/:cl: