Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks Runner-class and replaces weapons with factory subtype on the Elder #3059

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

meemofcourse
Copy link
Contributor

About The Pull Request

Title. The Runner-class should now be able to dock, and the Elder's Illestrens + Arrows were replaced with factory variants.

Why It's Good For The Game

  • Ship working good.
  • Elder is an SRM ship, which uses Hunter's Pride weapons. The factory variants are intended for SRM ships.

Changelog

🆑
balance: The Elder's Illesterns and Arrows are now factory-variant.
fix: The Runner should be able to dock now.
/:cl:

@meemofcourse meemofcourse requested a review from a team as a code owner June 1, 2024 18:54
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Jun 1, 2024
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im going to kiss you
the factory flaming arrows could be the flaming bolt instead, since FB uses brass
/obj/item/gun/ballistic/shotgun/flamingarrow/bolt

@meemofcourse
Copy link
Contributor Author

the factory flaming arrows could be the flaming bolt instead, since FB uses brass /obj/item/gun/ballistic/shotgun/flamingarrow/bolt

there was already a bolt variant in the elder, so i decided to keep it but replacing the arrows. that gives us two factory arrows and one bolt

Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok

@rye-rice rye-rice added this pull request to the merge queue Jun 2, 2024
Merged via the queue into shiptest-ss13:master with commit 2d692fd Jun 2, 2024
14 checks passed
@meemofcourse meemofcourse deleted the runner branch June 2, 2024 22:02
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
…Elder (shiptest-ss13#3059)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

Title. The Runner-class should now be able to dock, and the Elder's
Illestrens + Arrows were replaced with factory variants.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

* Ship working good.
* Elder is an SRM ship, which uses Hunter's Pride weapons. The factory
variants are intended for SRM ships.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
balance: The Elder's Illesterns and Arrows are now factory-variant.
fix: The Runner should be able to dock now.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants