small pr to make firemode code easier | or, how firemode code was so fucking terrible that this pr touches like 20-30 files #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| ///BASICALLY: the little button you select firing modes from? this is jsut the prefix of the icon state of that. For example, if we set it as "laser", the fire select will use "laser_single" and so on. | ||
| var/fire_select_icon_state_prefix = "" | ||
| ///If true, we put "safety_" before fire_select_icon_state_prefix's prefix. ex. "safety_laser_single" | ||
| var/adjust_fire_select_icon_state_on_safety = FALSE |
There was a problem hiding this comment.
this is a wordy var but shrug
github-actions
bot
added
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sun-Soaked
approved these changes
Jun 6, 2024
shiptest-server
pushed a commit
that referenced
this pull request
Jun 6, 2024
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jun 22, 2024
…fucking terrible that this pr touches like 20-30 files (shiptest-ss13#3061) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Wanted to add pride flags for pride month, but had to get this 'small pr' out the way. Oops. tldr; as a player, this should not affect you. Like at all. Move along This changes firemodes to not be fucking terrible codewise and to touch as a developer. Yes, i HAD to touch gun.dm that much. That was how deep rooted the rot was. Also get's rid of the 0.4 second hardcoded fire delay, now pistols and revolvers shoot as fast as they were intended. Great. This meant that i had to touch a bunch of numbers i set to 0 out of frustration at it not working, being completely unaware of the hardcoded fire delay. This also fixes the E-40 to have laser full auto and to have an ammo counter. I wasn't even trying to fix the E-40, but by unshittifying firemode code i got it to work. Wow. This should make the 3 upcoming gun expansions less ass to add. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: add: Changing firemodes on guns now have new sprites fix: The E-40 now works as intended! add: The E-40 now has an ammo counter balance: The P16 shoots slightly faster. balance: .299 Eoehoma caseless has gotten a slight nerf, while the E-40 shoots slightly faster. balance: Two E-40s max are obtainable from the black market should it spawn. Blank market price cap of the E-40 has also increased /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: retlaw34 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Wanted to add pride flags for pride month, but had to get this 'small pr' out the way. Oops.
tldr; as a player, this should not affect you. Like at all. Move along
This changes firemodes to not be fucking terrible codewise and to touch as a developer. Yes, i HAD to touch gun.dm that much. That was how deep rooted the rot was.
Also get's rid of the 0.4 second hardcoded fire delay, now pistols and revolvers shoot as fast as they were intended. Great. This meant that i had to touch a bunch of numbers i set to 0 out of frustration at it not working, being completely unaware of the hardcoded fire delay.
This also fixes the E-40 to have laser full auto and to have an ammo counter. I wasn't even trying to fix the E-40, but by unshittifying firemode code i got it to work. Wow.
Why It's Good For The Game
This should make the 3 upcoming gun expansions less ass to add.
Changelog
🆑
add: Changing firemodes on guns now have new sprites
fix: The E-40 now works as intended!
add: The E-40 now has an ammo counter
balance: The P16 shoots slightly faster.
balance: .299 Eoehoma caseless has gotten a slight nerf, while the E-40 shoots slightly faster.
balance: Two E-40s max are obtainable from the black market should it spawn. Blank market price cap of the E-40 has also increased
/:cl: