Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a few ships' TEG setups #3075

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

SapphicOverload
Copy link
Contributor

@SapphicOverload SapphicOverload commented Jun 6, 2024

About The Pull Request

Removes the disposals chutes some TEG setups have for you to throw lit welding tools into, and replaces them with proper igniters.

Why It's Good For The Game

Having a disposals chute to throw lit welding tools into was a stop-gap solution to igniters not working, which was fixed over a year ago in #1675.

Changelog

🆑
add: Adds an igniter and button to the TEG of every ship that was missing one
del: Removed the welding tool TEG chute some ships had
/:cl:

@SapphicOverload SapphicOverload requested a review from a team as a code owner June 6, 2024 01:09
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Jun 6, 2024
@thgvr
Copy link
Member

thgvr commented Jun 6, 2024

I don't think the igniters work

@SapphicOverload
Copy link
Contributor Author

I don't think the igniters work

I fixed them myself over a year ago (#1675) and the last time I played they still work.

@SapphicOverload
Copy link
Contributor Author

Tested the igniter again, still works.

@Apogee-dev
Copy link
Contributor

Apogee-dev commented Jun 8, 2024

I'd revert the changes on the Shetland specifically. It's deliberately kind of a shitbox with substandard equipment, the chute suits the vibes better.

@rye-rice rye-rice added this pull request to the merge queue Jul 8, 2024
Merged via the queue into shiptest-ss13:master with commit 4e0c5cf Jul 8, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jul 10, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Removes the disposals chutes some TEG setups have for you to throw lit
welding tools into, and replaces them with proper igniters.

## Why It's Good For The Game

Having a disposals chute to throw lit welding tools into was a stop-gap
solution to igniters not working, which was fixed over a year ago in
shiptest-ss13#1675.

## Changelog

:cl:
add: Adds an igniter and button to the TEG of every ship that was
missing one
del: Removed the welding tool TEG chute some ships had
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Removes the disposals chutes some TEG setups have for you to throw lit
welding tools into, and replaces them with proper igniters.

## Why It's Good For The Game

Having a disposals chute to throw lit welding tools into was a stop-gap
solution to igniters not working, which was fixed over a year ago in
shiptest-ss13#1675.

## Changelog

:cl:
add: Adds an igniter and button to the TEG of every ship that was
missing one
del: Removed the welding tool TEG chute some ships had
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
@SapphicOverload SapphicOverload deleted the one-year-too-late branch September 4, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants