Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(STANDBY FOR TITANFALL) Adds a new jungle ruin. #3078

Closed
wants to merge 3 commits into from

Conversation

enkidienne
Copy link
Contributor

About The Pull Request

Adds a new ruin: the crashed mech pods, to the jungle. 
image

Why It's Good For The Game

More ruins with content.

Changelog

🆑
add: Adds the crashed mech pods.
/:cl:

@enkidienne enkidienne requested a review from a team as a code owner June 6, 2024 04:23
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jun 6, 2024
@FalloutFalcon FalloutFalcon added the Ruin Ruin successfully tested. label Jun 10, 2024
Copy link
Contributor

@Zevotech Zevotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is missing a lot of details about the ruin, as well as pictures of the entire ruin in SDMM and with areas enabled. You also need a picture of the whole ruin ingame when spawned using the spawn planet/ruin verb.

This ruin does not meet current standards and has numerous issues. It contains too many dangerous enemies for such a small space, does not use the areas you created for it, and has various other design issues.
The crashed droppods make no sense, and would not work as a shuttle as they are now. This ruin has no explanation or reason for the deployment of these pods or who has sent them.

I recommend starting over from scratch map-wise, and mainly looking at jungle_interceptor.dmm as well as other crashed ship ruins for inspiration on how to map crashed objects. Try to make your ships look like ships.

Lore-wise, I would suggest reflavoring this as a CLIP mech deployment into a frontiersman-controlled area. Use CLIP/cmm signs and decals on the ships, and use frontiersmen mobs for the enemies. I can't find the messages of whoever told you not to use CLIP assets in ruins, so point me to them if its a problem so I can ask them for their reasoning.

@Zevotech
Copy link
Contributor

Closing this at the request of another maptainer. In its current state, it does not meet standards. A guide to designing ruins is being worked on right now to make those standards more apparent, and to help with making interactions like this smoother in the future. If you have any questions, please ask them in the discord and ping a maptainer to ask for advice and guidance when mapping future ruins.

@Zevotech Zevotech closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants