Raises character slot limit to 30 #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dont gorget! Possibly Zohil and Vigilitas and N+S |
|
dear god please no |
|
i support this whole-heartedly (i only have three free slots left), but the way the UI is currently set up, the character list already takes up too much space. if we want more character limit, we need to replace that with a drop-down or something. |
FalloutFalcon
previously requested changes
Jun 10, 2024
|
hey what if we let people export and import via text files to offload the storage to the user c: infinite character slots! |
|
sure but i wouldn't know how to code that |
|
dear god |
|
We need a usable UI before we get to this number, and even in your extreme case we don't need more then 30. |
rye-rice
dismissed
FalloutFalcon’s stale review
i have a character idea and im out of slots
Signed-off-by: rye-rice <[email protected]>
rye-rice
changed the title
|
spriters stole my pr can't have shit in shiptest dev |
shiptest-server
pushed a commit
that referenced
this pull request
Aug 29, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Sep 2, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request  mark was wrong god save us all <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game You know how we encourage playing different characters for the multiple factions? Currently, we have 6 player factions (CLIP, PGF, NT, SRM, Inteq, SolCon) plus 6 branches of the Syndicate (ACLF, Cybersun, Hardliners, SUNS, NGR, GEC) and 2 special factions (Fronties, Ramzi). If I wanted two characters for each faction (officer, assistant, medic, whatever) and one for each special faction, I'd need 26 slots. 40 seems good. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: Character slots have been raised to 40. BYOND members get 50. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: rye-rice <[email protected]> Co-authored-by: rye-rice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
mark was wrong god save us all
Why It's Good For The Game
You know how we encourage playing different characters for the multiple factions?
Currently, we have 6 player factions (CLIP, PGF, NT, SRM, Inteq, SolCon) plus 6 branches of the Syndicate (ACLF, Cybersun, Hardliners, SUNS, NGR, GEC) and 2 special factions (Fronties, Ramzi). If I wanted two characters for each faction (officer, assistant, medic, whatever) and one for each special faction, I'd need 26 slots. 40 seems good.
Changelog
🆑
add: Character slots have been raised to 40. BYOND members get 50.
/:cl: