Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members of the PGF start knowing Kalixcian Common #3090

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

meemofcourse
Copy link
Contributor

About The Pull Request

Uses an outfit post_equip (time will stop being linear before the prefs rework happens) in order to give people joining PGF ships the Kalixcian Common language.

Why It's Good For The Game

The military of a country should know how to speak that country's language.

Changelog

🆑
add: PGF jobs now grant you the Kalixcian Common language
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Jun 9, 2024
@Skies-Of-Blue
Copy link
Contributor

Hell yes

@thgvr
Copy link
Member

thgvr commented Jun 9, 2024

this is fine

@FalloutFalcon
Copy link
Member

merging without a test merge cause no pgf ship will be spawned in an uptime c:

@FalloutFalcon FalloutFalcon added this pull request to the merge queue Jun 10, 2024
Merged via the queue into shiptest-ss13:master with commit 859931f Jun 10, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

Uses an outfit post_equip (time will stop being linear before the prefs
rework happens) in order to give people joining PGF ships the Kalixcian
Common language.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

The military of a country should know how to speak that country's
language.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
add: PGF jobs now grant you the Kalixcian Common language
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@meemofcourse meemofcourse deleted the pgf-language branch September 8, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants