Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy/Laser guns display their charge and how many shots they have left on examine #3100

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

Gristlebee
Copy link
Contributor

About The Pull Request

Energy weapons now show on examine how much charge they have, or if they have a cell installed or not. They also show how many shots they have left on the current fire mode.

Also changes all the span classes to marcos

Why It's Good For The Game

QOL change, while it is true you have the charge indicator on the sprite, it's not the most reliable or accurate. This makes it a lot easier to keep track of how many shots you have left.

I also often see people try to charge guns with no cells and wonder why it doesnt work, so some extra textual indication couldnt hurt.

Changelog

🆑
add: Energy guns show how much charge and shots they have remaining, or if it doesnt have a cell installed on examine.
code: span classes to span macros for energy.dm
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Jun 11, 2024
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, it might be nice to make a generic "ammo_examine" proc for gun so we can ensure they are organized the same

@Imaginos16
Copy link
Member

lesgo

@Imaginos16 Imaginos16 added this pull request to the merge queue Jun 19, 2024
Merged via the queue into shiptest-ss13:master with commit 8cdaa01 Jun 19, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
…eft on examine (shiptest-ss13#3100)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Energy weapons now show on examine how much charge they have, or if they
have a cell installed or not. They also show how many shots they have
left on the current fire mode.

Also changes all the span classes to marcos

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

QOL change, while it is true you have the charge indicator on the
sprite, it's not the most reliable or accurate. This makes it a lot
easier to keep track of how many shots you have left.

I also often see people try to charge guns with no cells and wonder why
it doesnt work, so some extra textual indication couldnt hurt.

:cl:
add: Energy guns show how much charge and shots they have remaining, or
if it doesnt have a cell installed on examine.
code: span classes to span macros for energy.dm
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@Gristlebee Gristlebee deleted the energy-gun-examine branch July 21, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants