Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talos QOL Improvements #3105

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Conversation

Apogee-dev
Copy link
Contributor

@Apogee-dev Apogee-dev commented Jun 12, 2024

About The Pull Request

talos2

Makes some adjustments to address common issues with the Talos.

  • Areas have been changed so cargo no longer drops in the wings
  • Artificer Class II is now Honorable Artificer
  • Gas storage tank access buttons are restricted to Honorable Artificer
  • Comms and workshop have switched places
  • Crate shelves have been added to cargobay
  • Additional shuttle docks have been added on the starboard side
  • Added an autolathe to cargo
  • Removed Corpsmen

Why It's Good For The Game

Talos is a decent ship but had a few recurring problems. This fixes them.

Changelog

🆑
fix: Cargo pods no longer land in Talos maint
fix: Gas tanks on the Talos have higher security
fix: Talos now has an autolathe in cargo
/:cl:

@Apogee-dev Apogee-dev requested a review from a team as a code owner June 12, 2024 23:42
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jun 12, 2024
@Anticept
Copy link
Contributor

One small request: can a windoor be placed in front of the buttons?

A lot of the accidents that occur are misclicks while trying to access the computers. With a windoor its a sort of "last resort are you really sure?" Kind of thing.

@Apogee-dev
Copy link
Contributor Author

One small request: can a windoor be placed in front of the buttons?

A lot of the accidents that occur are misclicks while trying to access the computers. With a windoor its a sort of "last resort are you really sure?" Kind of thing.

Windoors on a wall tile or facing into one are illegal mapping techniques, I’d say. Looks terrible, doesn’t make sense from an IC perspective. Making it so that only the Honorable Artificer and Vanguard are capable of fucking it up should at least help.

@Anticept
Copy link
Contributor

... I know what we need. Guarded switches. Takes a do_after to unlatch, flip up the guard, and press the button.

Copy link
Contributor

@Zevotech Zevotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
Both the items in the locker and the job datum itself still say "Artificer Class II"
Also, you can cut the corpsman slots down to 1 or nix them entirely.
Maybe see if you can put something in the bridge to tell them to work with a Valor/Colossus so it gets through their heads.

@Apogee-dev Apogee-dev dismissed Zevotech’s stale review June 28, 2024 20:13

Implemented requested changes

@rye-rice rye-rice added this pull request to the merge queue Jul 8, 2024
Merged via the queue into shiptest-ss13:master with commit b049c3b Jul 8, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jul 10, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![talos2](https://github.com/shiptest-ss13/Shiptest/assets/60533805/f7fb731c-c2e6-4360-8c32-1375c2fe99f6)

Makes some adjustments to address common issues with the Talos.

- Areas have been changed so cargo no longer drops in the wings
- Artificer Class II is now Honorable Artificer
- Gas storage tank access buttons are restricted to Honorable Artificer
- Comms and workshop have switched places
- Crate shelves have been added to cargobay
- Additional shuttle docks have been added on the starboard side
- Added an autolathe to cargo
- Removed Corpsmen

## Why It's Good For The Game

Talos is a decent ship but had a few recurring problems. This fixes
them.

## Changelog

:cl:
fix: Cargo pods no longer land in Talos maint
fix: Gas tanks on the Talos have higher security
fix: Talos now has an autolathe in cargo
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![talos2](https://github.com/shiptest-ss13/Shiptest/assets/60533805/f7fb731c-c2e6-4360-8c32-1375c2fe99f6)

Makes some adjustments to address common issues with the Talos.

- Areas have been changed so cargo no longer drops in the wings
- Artificer Class II is now Honorable Artificer
- Gas storage tank access buttons are restricted to Honorable Artificer
- Comms and workshop have switched places
- Crate shelves have been added to cargobay
- Additional shuttle docks have been added on the starboard side
- Added an autolathe to cargo
- Removed Corpsmen

## Why It's Good For The Game

Talos is a decent ship but had a few recurring problems. This fixes
them.

## Changelog

:cl:
fix: Cargo pods no longer land in Talos maint
fix: Gas tanks on the Talos have higher security
fix: Talos now has an autolathe in cargo
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants