Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valor Remap, Minor Inteq Code Tweaks #3115

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

meemofcourse
Copy link
Contributor

@meemofcourse meemofcourse commented Jun 16, 2024

About The Pull Request

imagen
imagen

  • Remaps certain parts of the Valor. The Haste has not been touched apart from a single handrail.
  • The Valor now has a Shuttle Pilot, and a Shuttle Corpsman. The Shuttle Pilot gets an office and an outfit.
  • The Vanguard basetype was changed to be consistent with the other outfits (e.g. empty subtype instead of being empty by default)

Why It's Good For The Game

  • there was complaints that the valor sucked
  • born to map dmm is a fuck 地图 strongdmm 2019 i am maptainer 410,757,864,350 mapping sins

Changelog

🆑
balance: Remapped the Valor, with two extra jobs (Shuttle Corpsman, Shuttle Pilot).
code: The Vanguard base outfit starts with gear.
/:cl:

@meemofcourse meemofcourse requested a review from a team as a code owner June 16, 2024 18:06
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jun 16, 2024
Copy link
Contributor

@Zevotech Zevotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and normal to me

@Slim-Pickems
Copy link

Shuttle Corpsman ID does not differentiate from regular corpsman. Still says just Corpsman. Unsure if this is intentional or is know and to be fixed later.

@meemofcourse
Copy link
Contributor Author

intentional

@firebudgy
Copy link
Contributor

image
Once you see it you can't unsee it. (Duplicated box corner decal)

@rye-rice rye-rice added this pull request to the merge queue Jul 11, 2024
Merged via the queue into shiptest-ss13:master with commit 2a02ee2 Jul 11, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jul 13, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/67b0dbfa-3b5a-45fa-b6ee-2dab27b8c755)

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/8a62c180-cc96-449c-95cb-194685a789fa)

* Remaps certain parts of the Valor. The Haste has not been touched
apart from a single handrail.
* The Valor now has a Shuttle Pilot, and a Shuttle Corpsman. The Shuttle
Pilot gets an office and an outfit.
* The Vanguard basetype was changed to be consistent with the other
outfits (e.g. empty subtype instead of being empty by default)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
* there was complaints that the valor sucked
* born to map dmm is a fuck 地图 strongdmm 2019 i am maptainer
410,757,864,350 mapping sins

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
balance: Remapped the Valor, with two extra jobs (Shuttle Corpsman,
Shuttle Pilot).
code: The Vanguard base outfit starts with gear.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/67b0dbfa-3b5a-45fa-b6ee-2dab27b8c755)

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/8a62c180-cc96-449c-95cb-194685a789fa)

* Remaps certain parts of the Valor. The Haste has not been touched
apart from a single handrail.
* The Valor now has a Shuttle Pilot, and a Shuttle Corpsman. The Shuttle
Pilot gets an office and an outfit.
* The Vanguard basetype was changed to be consistent with the other
outfits (e.g. empty subtype instead of being empty by default)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
* there was complaints that the valor sucked
* born to map dmm is a fuck 地图 strongdmm 2019 i am maptainer
410,757,864,350 mapping sins

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
balance: Remapped the Valor, with two extra jobs (Shuttle Corpsman,
Shuttle Pilot).
code: The Vanguard base outfit starts with gear.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
FalloutFalcon pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants