Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mob trophies will no longer attempt to drop if there aren't any #3116

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

SomeguyManperson
Copy link
Contributor

About The Pull Request

killing 200000 goliaths so I can harvest nothing from them and upgrade my crusher with no trophies

Why It's Good For The Game

runtime I think

Changelog

🆑
fix: mobs will no longer stick around after being butchered sometimes
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Jun 16, 2024
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. I really did not test that change it seems like, I don't remember encountering this issue, thanks for the fix.

@FalloutFalcon FalloutFalcon added the Fix Causes more bugs in the future that we won't know about. label Jun 18, 2024
@FalloutFalcon FalloutFalcon added this pull request to the merge queue Jun 18, 2024
Merged via the queue into shiptest-ss13:master with commit d98aa76 Jun 18, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
…test-ss13#3116)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

killing 200000 goliaths so I can harvest nothing from them and upgrade
my crusher with no trophies

runtime I think

:cl:
fix: mobs will no longer stick around after being butchered sometimes
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

Signed-off-by: Theos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Fix Causes more bugs in the future that we won't know about.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants