Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailthump emote tied to tail instead of species #3124

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

generalthrax
Copy link
Contributor

About The Pull Request

you can now tailthump if you have a tail organ instead of being specifically tied to srothy (vox can still tail thump even though they have no tail organ)

Why It's Good For The Game

this was made for elzu in mind but you could do it if you have like a fox tail or something. the thumpers

Changelog

🆑
add: You can now tail thump if you have a tail instead of it being tied to species
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Jun 18, 2024
@Anticept
Copy link
Contributor

Technically, this enables the sound for anyone with a tail. Tailthump itself isn't species specific, at least not in this file.

@Imaginos16
Copy link
Member

Technically, this enables the sound for anyone with a tail. Tailthump itself isn't species specific, at least not in this file.

Is it that much of an issue though? Any animal with a tail can in theory thump the ground with it. Maybe someone with a cat tail doing it is a bit weird, but I think it's weirder that elzu or fox people with the tails can't when they very much should be able to.

@thgvr
Copy link
Member

thgvr commented Jun 19, 2024

I don't think this should work for the smaller tails we added (rabbit,dog, etc)

@Anticept
Copy link
Contributor

Anticept commented Jun 19, 2024

Technically, this enables the sound for anyone with a tail. Tailthump itself isn't species specific, at least not in this file

Is it that much of an issue though? Any animal with a tail can in theory thump the ground with it. Maybe someone with a cat tail doing it is a bit weird, but I think it's weirder that elzu or fox people with the tails can't when they very much should be able to.

There is a misunderstanding. I am pointing this out because the emote is already available to all. What is being changed is making the sound play for all. I am pointing out that the changelog and PR description are slightly misleading.

@Imaginos16
Copy link
Member

Well, I trust players will be able to use this emote when appropriate.

@Imaginos16 Imaginos16 added this pull request to the merge queue Jun 21, 2024
Merged via the queue into shiptest-ss13:master with commit 6f675a9 Jun 21, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
you can now tailthump if you have a tail organ instead of being
specifically tied to srothy (vox can still tail thump even though they
have no tail organ)

this was made for elzu in mind but you could do it if you have like a
fox tail or something. the thumpers

:cl:
add: You can now tail thump if you have a tail instead of it being tied
to species
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants