Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes shoddy 'active' state for holopads that was causing negative power draw. #3128

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

Thera-Pissed
Copy link
Contributor

About The Pull Request

I implemented the active state for this wrong, and it's better if it doesn't have one for now.

Why It's Good For The Game

bugs bad functional power good

Changelog

🆑
fix: infinite negative power draw while calling your grandmother no longer happens.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Jun 20, 2024
@Imaginos16 Imaginos16 added this pull request to the merge queue Jun 21, 2024
Merged via the queue into shiptest-ss13:master with commit d17d273 Jun 21, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
…power draw. (shiptest-ss13#3128)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

I implemented the active state for this wrong, and it's better if it
doesn't have one for now.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

bugs bad functional power good
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
fix: infinite negative power draw while calling your grandmother no
longer happens.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants