Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Deathsquadening #3182

Closed

Conversation

Latentish
Copy link
Member

@Latentish Latentish commented Jul 6, 2024

About The Pull Request

This redoes the descriptions of all deathsquad related items save like, the ID. Removes the NT documents from THE CLAW, buffs deathsquad hardsuits by giving them 80 in laser and energy (to match the other stats), and changes the death commando outfits slightly.
The deathsquad now actually has their own subshuttle.
image

Why It's Good For The Game

The deathsquad were NT associated prior to this. We want them to be associated with a comic series and be dubiously real. They now belong to an unnamed shadow organization of undescribed scope and power, with the best gear available. Because the dsquad exist to be the strongest unit in game for admins to let players clean up their messes with guns.

Changelog

🆑phoaly
add: reflavored the dsquad entirely
add: watchman-class subshuttle
/:cl:

Latentish added 3 commits July 5, 2024 21:44
- this rewrites every description referencing the deathsquad.
- buffs the dsquad armor for energy and laser to 80 to match their other stats
- removes the nanotrasen documents from claw
- replaces centcom uniform with black jumpsuit
- changes death_commando/officer to death_commando/shielded, renamed it to Death Commando Solo, and makes it change the hardsuit to the shielded version instead of giving them a weird cc beret
- forgor 💀 to change the associated helmet path smile
@github-actions github-actions bot added the Code change Watch something violently break. label Jul 6, 2024
@github-actions github-actions bot requested a review from FalloutFalcon July 6, 2024 05:08
Latentish added 2 commits July 6, 2024 17:11
- grammatical error fixes
- fixes the outfit
- adds the framework for the watchman
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Jul 7, 2024
- finishes the deathsquad subshuttle map
@Latentish Latentish changed the title Deathsquad reflavoring The Deathsquadening Jul 8, 2024
Latentish and others added 4 commits July 7, 2024 18:11
@Latentish Latentish marked this pull request as ready for review August 2, 2024 03:03
@Latentish Latentish requested a review from a team as a code owner August 2, 2024 03:03
Copy link
Contributor

@meemofcourse meemofcourse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen
this seems like a bad idea

code/datums/ert.dm Outdated Show resolved Hide resolved
code/modules/clothing/outfits/standard.dm Outdated Show resolved Hide resolved
code/modules/projectiles/guns/energy/pulse.dm Outdated Show resolved Hide resolved
_maps/shuttles/subshuttles/Subshuttle Catalog.txt Outdated Show resolved Hide resolved
Latentish and others added 2 commits August 12, 2024 21:03
Co-authored-by: meem <[email protected]>
Signed-off-by: Latency <[email protected]>
- changes the shuttle name
- changes the pulse carbine description
- changes the undershirt for the dsquad is now the military combat uniform.
- removes explosive walls
Copy link
Contributor

@meemofcourse meemofcourse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will change the outfits to work with the job system later but i think this is good

Copy link
Contributor

@Gristlebee Gristlebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So at a first glance:

  • You're missing pictures of this ship in strongdmm with areas, and ingame.
  • When spawned in game the ship flies backwards.
  • There appears to be atmos differences in the ship on spawn, which throws everything around on spawn.
  • Holofields are not anchored.
  • The widebands overlay oddly when the ship is rotated vertically.
    image
  • Same with the railing over the lockers.
    image
  • The bomb casing doesn't fit in the locker
    image
  • the manifold here spawns under the tile unlike the rest of pipes, making it look inconsistent.
    image
  • One side of the wing is smoothed, while the other is angled.
    image

@Latentish Latentish marked this pull request as draft September 20, 2024 10:54
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 23, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@thgvr
Copy link
Member

thgvr commented Dec 3, 2024

Re-open this if you're coming back to it.

@thgvr thgvr closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Merge Conflict Use Git Hooks, you're welcome.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants