-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crying Sun Job Updates / PGF Clothing Cold Protections #3190
Conversation
If the Bridge Officer isn’t actually an officer, I’d choose a job title that doesn’t imply as much. Why not something more explicit about their primary role, like Helmsman or Navigator or somesuch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't not work. The cups are literally hanging off the table, the bottle is scrunched in with the plushie. If you're going to add glasses and a bottle here, redo the table to make it look nice. You can edit the layer var on some of the objects like the window/girder/shutter so you can move the lamp up in front of it. But overall you're going to need to redo this table or remove the glasses and bottle.
This also needs some work. If you're going to pixelshift a locker's contents, you can't have them underlap the light on that tile. You should move the light to the middle wall, and redo this locker. Remember not to have your items overlap a wall, and moke sure the locker actually has some good room to be clicked on. I suggest spreaeding things out and paying attention to the layering of objects, as the goal is to make it so as many of those items can be clicked o n without a context menu as possible, without looking like a mess. Something I would avoid is space between items like you have with the jacket and the duffelbag. Though I have to be honest I don't want the helmsmen having half these items. They should really just being wearing standard navy gear, which they can get in the crew area. I don't really see why they need a locker.
Also please add an image of the bridgte without the windows, grills, or shutters, as I'd like to make sure that wiring and firelocks are good.
"Marine Sergeant": { | ||
"outfit": "/datum/outfit/job/gezena/hos", | ||
"Helmsman": { | ||
"outfit": "/datum/outfit/job/gezena/hop", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this back to assistant/bridge or change that to another version. I'd also like to see what all you put in their locker, because I don't really think they need one.
|
||
/obj/item/paper/fluff/shuttles/cryingsun | ||
name = "Electro-proofing Your Crying Sun" | ||
default_raw_text = "Quartermaster said we have to drag these grounding rods and tesla coils on for you, and you might be wondering how you can use them. Supposedly, if you're not needing external defenses or asteroid turrets, you can replace each of the external turrets with a tesla coil and generate some power running through any storms. The two empty platings in the back fit grounding rods - fit all the spots and you should be fully covered." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't entirely accurate. Most of the turrets fit tesla grounds. Look at the wire placement to see which ones. This implies only the two at the back do.
@@ -260,20 +265,20 @@ | |||
item_state = "blackcloth" | |||
|
|||
/obj/item/clothing/neck/cloak/gezena/lead | |||
name = "sergeant's Azuilhauz" | |||
desc = "The “Aziulhauz”, or “rank-cape”, is the method with which PGF military members display their rank to others. Wearing one while on duty is required by uniform code. This variant displays the wearer's rank as a squad commander." | |||
name = "squad leader's Azuilhauz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to Marine Officer's Azuilhauz as they're a Lieutenant
name = "sergeant's Azuilhauz" | ||
desc = "The “Aziulhauz”, or “rank-cape”, is the method with which PGF military members display their rank to others. Wearing one while on duty is required by uniform code. This variant displays the wearer's rank as a squad commander." | ||
name = "squad leader's Azuilhauz" | ||
desc = "The “Aziulhauz”, or “rank-cape”, is the method with which PGF military members display their rank to others. Wearing one while on duty is required by uniform code. This variant displays the wearer's rank as a marine squad leader." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, change to "rank as a marine officer"
too tired to try and keep fighting for even the smallest give toward what I think would be better for this faction |
About The Pull Request
A FULL review of what this PR does:
The new bridge:
The curious drinks:
Why It's Good For The Game
Modernizing and keeping our ships up to state is important. Making the role not a baseline crewmate helps to appeal to players who want to get into the faction whilst still permitting crewmates to shadow ANYONE
As for the silk/betiz changes, it's good to allow crew to deploy without needing to equip a softsuit, as Gezenan winter coats don't exist, nor would they fit well, in my opinion. Offering trade-offs for variants that make sense in-lore is always nice
Changelog
🆑
code: Bridge Crew on the Crying Sun is now an Helmsman, with their own locker. Not a head
code: Marine Sergeant is now an officer with name changed to Marine Lieutenant
code: Several item placement adjustments on the Crying Sun have been made to better intend design
balance: Silkenweave jackets and Betzu hats now provide cold protection but no armor
fix: Bottles that advertise themselves as mead should be consumable by sarathi now
balance: Crying Sun now has 4 combustion/2 ion engines instead of 2/4
fix: Fixes the turrets on the Crying Sun and the Nail
/:cl: