Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sec Vest Breakpoints & Armor Rebalances #3216

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

Apogee-dev
Copy link
Contributor

@Apogee-dev Apogee-dev commented Jul 17, 2024

About The Pull Request

Makes a number of balance changes to common armor pieces:

  • basic armor vests and helmets are buffed to 35 bullet/laser to hit several HP/AP damage breakpoints
  • armored coats have been standardized to have only CHEST | GROIN armor protection. They still provide cold/heat protection for the arms (and legs for trench+greatcoats). Full-body suits, such as riot armor and plate armor, still provide full body protection.
  • SUNS and SolCon armor get the same treatment and have been converted to basic vest armor, not bulletproof. Now the factions that really like swords actually have melee armor.
  • HOS and captain coats for various factions have had their armor adjusted to be consistent with one another. Flashy parade coats still get the nerfed armor most of them already had.
  • Armor has been stripped from a beret or two I forgot about.

Why It's Good For The Game

Hollow Point and Armor Piercing ammo didn't hit useful breakpoints vis-a-vis performance against common armor types that actually put them in their niches. 35 armor is the breakpoint where hollow point becomes worse than normal ammo, so this should make sec vests actually matter more often. Peacekeepers with their full-body bulletproof armor were utterly cracked. Armored coats were pretty inconsistent between factions as to whether or not they provided limb protection and how much protection they offered. This PR makes things more consistent across the board, so you can usually guess what kind of armor protection you'll be facing at a glance without having to remember a bunch of weird code inconsistencies.

Changelog

🆑
balance: SUNS and SolCon armor now uses standard armor rather than bulletproof
balance: Normalized armor values between various faction helmets, coats, and vests
balance: Armored coats now provide armor protection for the chest and groin only; environmental protection unchanged
fix: removed armor from some overlooked berets and soft hats
/:cl:

@Apogee-dev Apogee-dev requested a review from a team as a code owner July 17, 2024 19:23
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jul 17, 2024
@rye-rice
Copy link
Member

rye-rice commented Aug 3, 2024

This needs a tm on Saturday, if not illl probablymerge,

@rye-rice rye-rice added this pull request to the merge queue Aug 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 6, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@thgvr
Copy link
Member

thgvr commented Aug 25, 2024

conflicts

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Aug 28, 2024
@thgvr thgvr enabled auto-merge August 28, 2024 21:47
@thgvr thgvr added this pull request to the merge queue Aug 28, 2024
Merged via the queue into shiptest-ss13:master with commit ab47f2d Aug 28, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Sep 2, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Makes a number of balance changes to common armor pieces:

- basic armor vests and helmets are buffed to 35 bullet/laser to hit
several HP/AP damage breakpoints
- armored coats have been standardized to have only CHEST | GROIN armor
protection. They still provide cold/heat protection for the arms (and
legs for trench+greatcoats). Full-body suits, such as riot armor and
plate armor, still provide full body protection.
- SUNS and SolCon armor get the same treatment and have been converted
to basic vest armor, not bulletproof. Now the factions that really like
swords actually have melee armor.
- HOS and captain coats for various factions have had their armor
adjusted to be consistent with one another. Flashy parade coats still
get the nerfed armor most of them already had.
- Armor has been stripped from a beret or two I forgot about.

## Why It's Good For The Game

Hollow Point and Armor Piercing ammo didn't hit useful breakpoints
vis-a-vis performance against common armor types that actually put them
in their niches. 35 armor is the breakpoint where hollow point becomes
worse than normal ammo, so this should make sec vests actually matter
more often. Peacekeepers with their full-body bulletproof armor were
utterly cracked. Armored coats were pretty inconsistent between factions
as to whether or not they provided limb protection and how much
protection they offered. This PR makes things more consistent across the
board, so you can usually guess what kind of armor protection you'll be
facing at a glance without having to remember a bunch of weird code
inconsistencies.

## Changelog

:cl:
balance: SUNS and SolCon armor now uses standard armor rather than
bulletproof
balance: Normalized armor values between various faction helmets, coats,
and vests
balance: Armored coats now provide armor protection for the chest and
groin only; environmental protection unchanged
fix: removed armor from some overlooked berets and soft hats
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants