Extra ration icons #3290
Merged
Extra ration icons #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
sorry i copied and pasted this code from discord
shiptest-server
pushed a commit
that referenced
this pull request
Aug 25, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Aug 26, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds a unique emblem for each ration box, providing a visual cue for what kind of food can be found inside, adds coloring to the condiment sprites, and creates new sprites for the ration heater side-size rations, drink mixes, and vodka! Ration boxes  Side ration, heater, and vodka  Drink mixes  Condiments  <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Currently, the ration heater and vodka use the same icon as the ration box, all ration boxes look the same, "snack" and "side" rations look identical, condiments and drink packs use the same model, and filling color doesn't work for either one. This PR gives each ration a unique icon to be recognized by. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> Maintainer edit: cleaned up changelog ## Changelog :cl:Aquidu add: Rations now have icons that help show the contents. add: Condiments and drink mixes now have colors when full to help show the contents. add: Unique sprites for the ration heater, drink packs ration drinks, and "side" category rations. code: Changes the sound effect for opening the drink ration to the bottle cap sound to line up with the icon. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a unique emblem for each ration box, providing a visual cue for what kind of food can be found inside, adds coloring to the condiment sprites, and creates new sprites for the ration heater side-size rations, drink mixes, and vodka!
Ration boxes
Side ration, heater, and vodka
Drink mixes
Condiments
Why It's Good For The Game
Currently, the ration heater and vodka use the same icon as the ration box, all ration boxes look the same, "snack" and "side" rations look identical, condiments and drink packs use the same model, and filling color doesn't work for either one. This PR gives each ration a unique icon to be recognized by.
Maintainer edit: cleaned up changelog
Changelog
🆑Aquidu
add: Rations now have icons that help show the contents.
add: Condiments and drink mixes now have colors when full to help show the contents.
add: Unique sprites for the ration heater, drink packs ration drinks, and "side" category rations.
code: Changes the sound effect for opening the drink ration to the bottle cap sound to line up with the icon.
/:cl: