Fixes power consumption for mech movement and reduces the amount of power the durand shield consumes #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 25, 2024
…ower the durand shield consumes (#3300) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> - renames normal_step_energy_drain to base_step_energy_drain, which holds the base energy consumption per move. step_energy_drain now handles how much power should be consumed after modifiers. - Mechs used a hardcoded calculation instead of whatever their actual value should be for movement power consumption. This meant swapping out stock parts could give you a worse power consumption and then it already started with, and made the gygax consume 4 times more power then it shouldve with it's leg actuators. Fixes that. - Reduces the power drain of the durand shield from being hit, and it's power efficiency is increased with better capacitors. Increases the passive drain for having it on. ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> Mech abilities were a trap with how much power they consumed, and would often leave you a sitting duck with no power rather than actually helping you. It's a bit unintuitive that it's more efficient to tank with your durand instead of your shield, since a single 9mm bullet would shave 2000 charge off your cell. The shield is now more "durable" since it consumes less charge actively. Passive drain has been increased as a trade off. Being hit is less of a concern, but keeping your shield on unnecessarily will rapidly drain your battery. Bugfixes in general are good, and the gygax should no longer consume obscene amounts of power. ## Changelog :cl: balance: Durand shield consumes less charge on being hit, passive drain increased. fix: Mechs consume the correct amount of power on movement. refactor: normal_step_energy_drain is now base_step_energy_drain /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
shiptest-server
pushed a commit
that referenced
this pull request
Aug 25, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Aug 27, 2024
…ower the durand shield consumes (shiptest-ss13#3300) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> - renames normal_step_energy_drain to base_step_energy_drain, which holds the base energy consumption per move. step_energy_drain now handles how much power should be consumed after modifiers. - Mechs used a hardcoded calculation instead of whatever their actual value should be for movement power consumption. This meant swapping out stock parts could give you a worse power consumption and then it already started with, and made the gygax consume 4 times more power then it shouldve with it's leg actuators. Fixes that. - Reduces the power drain of the durand shield from being hit, and it's power efficiency is increased with better capacitors. Increases the passive drain for having it on. ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> Mech abilities were a trap with how much power they consumed, and would often leave you a sitting duck with no power rather than actually helping you. It's a bit unintuitive that it's more efficient to tank with your durand instead of your shield, since a single 9mm bullet would shave 2000 charge off your cell. The shield is now more "durable" since it consumes less charge actively. Passive drain has been increased as a trade off. Being hit is less of a concern, but keeping your shield on unnecessarily will rapidly drain your battery. Bugfixes in general are good, and the gygax should no longer consume obscene amounts of power. ## Changelog :cl: balance: Durand shield consumes less charge on being hit, passive drain increased. fix: Mechs consume the correct amount of power on movement. refactor: normal_step_energy_drain is now base_step_energy_drain /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Constellado
pushed a commit
to Constellado/PentestOld
that referenced
this pull request
Aug 27, 2024
…ower the durand shield consumes (shiptest-ss13#3300) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> - renames normal_step_energy_drain to base_step_energy_drain, which holds the base energy consumption per move. step_energy_drain now handles how much power should be consumed after modifiers. - Mechs used a hardcoded calculation instead of whatever their actual value should be for movement power consumption. This meant swapping out stock parts could give you a worse power consumption and then it already started with, and made the gygax consume 4 times more power then it shouldve with it's leg actuators. Fixes that. - Reduces the power drain of the durand shield from being hit, and it's power efficiency is increased with better capacitors. Increases the passive drain for having it on. ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> Mech abilities were a trap with how much power they consumed, and would often leave you a sitting duck with no power rather than actually helping you. It's a bit unintuitive that it's more efficient to tank with your durand instead of your shield, since a single 9mm bullet would shave 2000 charge off your cell. The shield is now more "durable" since it consumes less charge actively. Passive drain has been increased as a trade off. Being hit is less of a concern, but keeping your shield on unnecessarily will rapidly drain your battery. Bugfixes in general are good, and the gygax should no longer consume obscene amounts of power. ## Changelog :cl: balance: Durand shield consumes less charge on being hit, passive drain increased. fix: Mechs consume the correct amount of power on movement. refactor: normal_step_energy_drain is now base_step_energy_drain /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Mech abilities were a trap with how much power they consumed, and would often leave you a sitting duck with no power rather than actually helping you. It's a bit unintuitive that it's more efficient to tank with your durand instead of your shield, since a single 9mm bullet would shave 2000 charge off your cell.
The shield is now more "durable" since it consumes less charge actively. Passive drain has been increased as a trade off. Being hit is less of a concern, but keeping your shield on unnecessarily will rapidly drain your battery.
Bugfixes in general are good, and the gygax should no longer consume obscene amounts of power.
Changelog
🆑
balance: Durand shield consumes less charge on being hit, passive drain increased.
fix: Mechs consume the correct amount of power on movement.
refactor: normal_step_energy_drain is now base_step_energy_drain
/:cl: