-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes insulation from captain and combat gloves, hardsuits #3319
Removes insulation from captain and combat gloves, hardsuits #3319
Conversation
removes shock insulation from non-engi gloves and hardsuits, adds it to engi soft suits
replaces combats with insuls on maps that give them to engineers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dunno whats goin on with the varibles getting reorginized in those DMMs.
I wish hardsuits could keep some siemens_coefficent but it currently functions like a binary so shrug.
Also modsuits have protection still.
do modsuits have protection? Because I searched for everything with a siemens_coefficient variable of 0 when I was doing this. do they use an alternate method or something. Also, does siemens_coefficient actually function like a binary? Most gloves have a coefficient of 0.5 and latex has 0.3, which seems like it would indicate otherwise |
A suggestion I might have as an alternative: shock thresholds. Gloves would protect against low power, but at extreme power even hardsuits would leak through. |
This is an idea I've thought about before, where high voltage would even bypass proper insulated gloves, but it'd be significantly more work. And a bit beside the point of this particular pr, since i mostly just wanted to de-insulate combat and captain gloves. Maybe later. |
code/modules/mod/mod_theme.dm, Line 31 and 317 the damage is multiplied by the coeff sigh.... oh and also a very large amount of shocks, just skip gloves, no protection frick you. |
…t-ss13#3319) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Removes electrical insulation from all gloves except for insulated gloves and their children (including captain, tackler, and combat gloves) and nixes the siemens coefficient on hardsuits that aren't engineer hardsuits of some form. Adds siemens coeff to engineering space suits. Replaces combat gloves with insulated gloves in outfit datums and locker contents for engineers. ## Why It's Good For The Game shock protection is a bit too widely available with how many jobs spawn with combats and how many captain players are in an average round. Since electrical hazards should become a bit more significant in the future due to planned mapping hazards and potentially electrical weapons, this generally reduces it to the players directly responsible for engineering in some capacity. We shouldn’t have ships where the entire crew is shockproof at roundstart- if you want to do that it should require buying some crates, at least. ## Changelog :cl: balance: Removed electrical insulation from all gloves except insulated gloves balance: Removed siemens coefficient from hardsuits, except for engi atmos and CE balance: Added siemens coefficient to engineer space suits balance: Replaced combat gloves with insulated gloves for some factions' engineer lockers /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
About The Pull Request
Removes electrical insulation from all gloves except for insulated gloves and their children (including captain, tackler, and combat gloves) and nixes the siemens coefficient on hardsuits that aren't engineer hardsuits of some form. Adds siemens coeff to engineering space suits. Replaces combat gloves with insulated gloves in outfit datums and locker contents for engineers.
Why It's Good For The Game
shock protection is a bit too widely available with how many jobs spawn with combats and how many captain players are in an average round. Since electrical hazards should become a bit more significant in the future due to planned mapping hazards and potentially electrical weapons, this generally reduces it to the players directly responsible for engineering in some capacity. We shouldn’t have ships where the entire crew is shockproof at roundstart- if you want to do that it should require buying some crates, at least.
Changelog
🆑
balance: Removed electrical insulation from all gloves except insulated gloves
balance: Removed siemens coefficient from hardsuits, except for engi atmos and CE
balance: Added siemens coefficient to engineer space suits
balance: Replaced combat gloves with insulated gloves for some factions' engineer lockers
/:cl: