Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cargo Missions (Pirate Bounties, Salvage) #3327

Merged
merged 24 commits into from
Nov 27, 2024

Conversation

generalthrax
Copy link
Contributor

@generalthrax generalthrax commented Sep 3, 2024

About The Pull Request

A few more missions to cargo. Should make them more varied, with some financial incentive for combat ships or scrappers to search for certain things

  • Add dogtags to Frontiersmen corpses
  • Add dogtags to Ramzi drops or have them spawn corpses with dogtag on them (ramzi mobs are kind of stupid i might change them)
  • Frontie Mission
  • Ramzi Mission
  • Turn in Protolathe Mission
  • Turn in RND Console Mission (may combine all three of these into one)
  • Remove Fishing Missions
  • Remove impossible missions like Capture Abandoned Floorbot and Capture Bluespace Watcher
  • Descriptions
  • Increase value of migo mission
  • Increase value of Strange Crystal mission
  • Dogtag sprites (courtesy of @rye-rice

(prices subject to change)

Why It's Good For The Game

More financial incentives to go hunt down the Pirate ruins for combat ships. A reason to stash up the rare machinery you find from ruins to sell them instead of Grinding RND And Getting Those Sweet Research Points

Crew bonding session of stripping dogtags from pirates, ensuring their bodies never return to their loved ones and you can rack in that sweet, sweet Inteq cash

Changelog

🆑
add: Adds Dogtag Missions to hunt down Ramzi Clique and Frontiersman NPCS from Ruins
add: Adds Salvage Missions to collect Protolathe or R&D Console Boards
del: Removes Fishing Missions
del: Removes impossible missions like Bluespace Watcher and Abandoned Floorbot
balance: Increases price of Migo missions to be on par with Legion
balance: Increases the value of Strange Crystal missions
del: Remove R&D design board from unlocked Protolathes and Science Protolathes
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Sep 3, 2024
@Martinpachu
Copy link
Contributor

who would EVER sell their RND? other than me

@generalthrax
Copy link
Contributor Author

Plenty would. Its also weighed to be Quite Rare so you're not stocking up like 8 RND boards for a shiptillion credits

@Madtankdriver
Copy link

The dog tags on corpses sounds like a pretty cool idea. I like it!

@Martinpachu
Copy link
Contributor

Martinpachu commented Sep 3, 2024

Plenty would. Its also weighed to be Quite Rare so you're not stocking up like 8 RND boards for a shiptillion credits

its less that you can get a bunch of them and more so that it's so rare and absurdly powerful that nobody would ever do it. i like it, though.

@generalthrax
Copy link
Contributor Author

I think you underestimate just how many people dislike interacting with RND. Outside of Gamers, at least. It'll be very low-weighted anyways, so w/e.

@Martinpachu
Copy link
Contributor

I think you underestimate just how many people dislike interacting with RND. Outside of Gamers, at least. It'll be very low-weighted anyways, so w/e.

i dont think the weighing matters a lot since rnd is sooo rare either way. not really a problem i just thought it was a little funny.

@Aquidu
Copy link
Contributor

Aquidu commented Sep 4, 2024

Thoughts on a potential mission where you have to turn in a canister of a certain gas?

@Apogee-dev
Copy link
Contributor

I think you underestimate just how many people dislike interacting with RND. Outside of Gamers, at least. It'll be very low-weighted anyways, so w/e.

i dont think the weighing matters a lot since rnd is sooo rare either way. not really a problem i just thought it was a little funny.

Don't worry! it's going to get rarer.

@thgvr
Copy link
Member

thgvr commented Sep 16, 2024

...are ramzi/frontiersmen mobs common enough for this?

@generalthrax
Copy link
Contributor Author

...are ramzi/frontiersmen mobs common enough for this?

Yes.

@generalthrax
Copy link
Contributor Author

This should be ready. I'm aware about Fallcon's dynamic mission stuff but I figured I'd get this out of the way to see if its compatible rather than just close this outright

@generalthrax generalthrax marked this pull request as ready for review October 14, 2024 22:21
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 19, 2024
Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still seems good for merge if you can manage to get a sprite for the dogtags and resolve the conflict since I think dynamic missions are still a little ways off

@generalthrax
Copy link
Contributor Author

Sounds good. I'll try and get it done once this uptime is over.

@generalthrax generalthrax requested a review from a team as a code owner November 12, 2024 06:29
@github-actions github-actions bot added the Sprites A bikeshed full of soulless bikes. label Nov 12, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Nov 12, 2024
@generalthrax
Copy link
Contributor Author

Conflicts are fixed and I now have a sprite courtesy of @rye-rice. This should be good to go.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Nov 14, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Sun-Soaked
Copy link
Member

fix checks and conflicts and I'll get it in

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Nov 20, 2024
Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also you gotta add a worn state for the dogtags too

@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Nov 27, 2024
Merged via the queue into shiptest-ss13:master with commit eb0c9b4 Nov 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants