Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.45-70 boxes hold 18 instead of 12, .45-70 specialty ammo black market #3333

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

generalthrax
Copy link
Contributor

@generalthrax generalthrax commented Sep 6, 2024

About The Pull Request

Doubles the amount of rounds in .45-70

Why It's Good For The Game

Beacon takes the cake for The Worst Ammo Efficiency In The Game By Far (500 credits for 12 bullets, you are Shooting 40 Credits Each Shot, the equivalent of shooting half a Plasteel Sheet each shot)

Changelog

🆑
balance: .45-70 boxes increased from 12 to 18
add: .45-70 hollow point boxes and A Singular .45-70 Explosive Round is now available in the black market
/:cl:

@generalthrax generalthrax marked this pull request as ready for review September 6, 2024 04:30
@github-actions github-actions bot added the Code change Watch something violently break. label Sep 6, 2024
@Apogee-dev
Copy link
Contributor

Apogee-dev commented Sep 6, 2024

Just reduce the price, don't double the size of the box. Most ammo boxes are around 2 reloads for the most notable gun that uses it (the ashhand revolver in this case), so the old capacity was in line with that. Too big and it starts to mess with inventory economy. .45-70 is still tied with .300 for having the highest damage for any normally obtainable, non-HP ammo type in the game and can fit in a handgun, so it should have a per-shot price that reflects that, accounting for any reductions in .300's price.

@generalthrax
Copy link
Contributor Author

generalthrax commented Sep 6, 2024

Most ammo boxes are around 2 reloads for the most notable gun that uses it

primary guns that have enough ammo for more than 2 reloads:

  • commander
  • stechkin
  • skm
  • illestren
  • scout
  • shadow
  • firebrand
  • hellfire / conflagration / brimstone / double barrel
  • candor / cobra-20
  • detective revolver / flaming arrow
  • vickland / inteq dmr

so thats every gun in the cargo catalog (the Exception to Most) barring the WT-550 / SKMv and the aforementioned Ashhand with enough ammo in one box for more than one reload. i dont see your point.

@Apogee-dev
Copy link
Contributor

Most ammo boxes are around 2 reloads for the most notable gun that uses it

primary guns that have enough ammo for more than 2 reloads:

* commander

* stechkin

* skm

* illestren

* scout

* shadow

* firebrand

* hellfire / conflagration / brimstone / double barrel

* candor / cobra-20

* detective revolver / flaming arrow

* vickland / inteq dmr

so thats every gun in the cargo catalog (the Exception to Most) barring the WT-550 / SKMv and the aforementioned Ashhand with enough ammo in one box for more than one reload. i dont see your point.

That's fair enough, but that's also a lot of bullets that do 45 damage each in a single small slot. At least make it 18 instead of 24 if you want to increase the size, because fully doubling it is too much in my opinion.

@generalthrax
Copy link
Contributor Author

I'll settle for that.

@generalthrax generalthrax changed the title .45-70 boxes hold 24 instead of 12 .45-70 boxes hold 18 instead of 12 Sep 6, 2024
@rye-rice rye-rice added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2024
@generalthrax generalthrax changed the title .45-70 boxes hold 18 instead of 12 .45-70 boxes hold 18 instead of 12, .45-70 hollow point to the black market Sep 6, 2024
@generalthrax
Copy link
Contributor Author

made a teensy tiny little change from #3334

@Apogee-dev
Copy link
Contributor

if you want to be REALLY funny you could add .45-70 explosive to the black market for some absolutely exorbitant price, but who knows what effect that would have on gameplay since that shit's guaranteed to blow a limb off if it hits one

@generalthrax
Copy link
Contributor Author

im not crazy enough to add that just yet

@Apogee-dev
Copy link
Contributor

think about it, black market listing for One Single Explosive Bullet. one thousand credits.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 17, 2024
@generalthrax
Copy link
Contributor Author

cooked

@generalthrax generalthrax changed the title .45-70 boxes hold 18 instead of 12, .45-70 hollow point to the black market .45-70 boxes hold 18 instead of 12, .45-70 specialty ammo black market Sep 17, 2024
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is funny and rare enough to probably not impact gameplay

@FalloutFalcon FalloutFalcon added this pull request to the merge queue Sep 20, 2024
Merged via the queue into shiptest-ss13:master with commit 9b6775a Sep 20, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Sep 22, 2024
shiptest-ss13#3333)

## About The Pull Request

Doubles the amount of rounds in .45-70

## Why It's Good For The Game

Beacon takes the cake for The Worst Ammo Efficiency In The Game By Far
(500 credits for 12 bullets, you are Shooting 40 Credits Each Shot, the
equivalent of shooting half a Plasteel Sheet each shot)

## Changelog

:cl:
balance: .45-70 boxes increased from 12 to 18
add: .45-70 hollow point boxes and A Singular .45-70 Explosive Round is
now available in the black market
/:cl:

---------

Signed-off-by: generalthrax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants