Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprinting #3339

Closed
wants to merge 5 commits into from
Closed

Sprinting #3339

wants to merge 5 commits into from

Conversation

thgvr
Copy link
Member

@thgvr thgvr commented Sep 6, 2024

About The Pull Request

Port of MrMelbert/MapleStationCode#353
Port of tgstation/tgstation#60479

!! CONFIG EDIT REQUIRED!!

game_options.txt
Recommended values:

  • RUN_DELAY 1.5
  • WALK_DELAY 2.5

Details:

  • Humans default to walk move intent.
  • Being on run intent drains a sprint bar, shown on your move intent selector.
    • You can run for 50 tiles (by default) without penalty (indicated by the sprint bar).
    • Running for longer than 50 tiles incurs a stamina cost for every tile sprinted.
    • You regenerate 0.5 tiles of sprint per second (Or 1 per life tick) while not sprinting.
    • Being stamcrit fully drains your sprint bar.
    • Stamina regenerating chemicals (such as stimulants) regenerate your sprint bar.
  • Walking no longer masks your footsteps.
    • todo, maybe port sneak mode or do it myself later.

Changelog

🆑 MrMelbert
add: Sprinting, by default hold alt to sprint or click on the "walk" ui object.
/:cl:

@github-actions github-actions bot added Config Watch us shake head admins violently until this gets merged. DME Edit Sound USSR Anthem 2.66 MB file. Code change Watch something violently break. labels Sep 6, 2024
@Anticept
Copy link
Contributor

Anticept commented Sep 6, 2024

Bay has a "creep" (walk) mode, run mode, and a "sprint" mode. Basically, while moving, if you are in run mode, you dont recover stamina, while in sprint you drain it, while sitting still or creeping you recover. Creep is very slow moving. slower than our old walk.

I do like how you can start drawing on your health stamina if you push past your limit. That's neat.

@thgvr
Copy link
Member Author

thgvr commented Sep 9, 2024

Feedback would be great if anyone is interested (I SEE YOU READING GITHUB RELAY CHANNEL)

@meemofcourse
Copy link
Contributor

i think this pr stinks

@generalthrax
Copy link
Contributor

generalthrax commented Sep 9, 2024

Pretty good. Sneak mode would be nice but you already got that planned. Currently, you can't walk past people on walk mode like you used to (hurts a lot on smaller ships like the Kilo). You can sprint with a jetpack while in space to go Crackhead Speed.

I'm also not sure if its this PR or something else but if you alt-click a tile (same button as sprinting) your game slows to a crawl.

@Gristlebee
Copy link
Contributor

Feedback would be great if anyone is interested (I SEE YOU READING GITHUB RELAY CHANNEL)

WAAAAAAAAAAAH-
Since walking is the new default movement, I think it would be good to have the tile swapping behavior from running moved to walking. Walking still currently blocks movement from other mobs, and makes moving around a bit awkward especially in cramped spaces.

It'd also be nice in my opinion if the sprint bar still regenerated on sprint mode while you're standing still, maybe at a reduced rate.

@thgvr
Copy link
Member Author

thgvr commented Sep 9, 2024

yeah the swap thing is a bug

It should also regenerate when it's not being used, I'd need to check

@DIB-DOG
Copy link
Contributor

DIB-DOG commented Sep 9, 2024

Not the biggest fan of the change personally and I think I prefer the old system, but I don't hate it and could definitely grow used to it.

However, I would complain that the general increase in movespeed, both to walking and running, feels too fast. I'm personally of the opinion that the old movespeeds with this system would be fine, perhaps with an increase to the run speed. Overall, my biggest complaint would be that the walking speed feels too fast.

If a 3 speed system was to be introduced though, like what Anticept described, that would definitely be ideal. Allowing for a walk run/jog, and a sprint mode sounds like an awesome level of control to have over player speed, especially for SS13

Last little bit. Is there any way to allow players to turn on or off the "run mode" activation noise? I never needed a little audio cue before, and I don't really need it now. I get that it helps with accessibility and some players might like it, so I'm not saying to axe it, but when I use the ALT key for other binds, the noise gets kind of annoying after a while.

@thgvr
Copy link
Member Author

thgvr commented Sep 9, 2024

I will probably remove the noise

@Zevotech
Copy link
Contributor

Zevotech commented Sep 9, 2024

The sound it makes is really, really bothersome. I can't be the only one that finds it really annoying hearing it whenever I try to alt-click something. I'd prefer if it was silent. It really doesn't need a noise for every single time it's active.

@Sun-Soaked
Copy link
Member

The noise drives me a little nuts but other than that I really like it
A visual indicator might be better

@tantspants
Copy link

I really don't think we need a sprint/stamina system. It really bogs down everything :(

@thgvr
Copy link
Member Author

thgvr commented Sep 11, 2024

Would you mind giving some more thoughts on what's wrong with it other than "I dont like it"?

@Orchidthederg
Copy link
Contributor

I feel like this new system is pretty clunky, and while maybe with some adjustment it could be gotten used to, the hotkey conflict is fairly major. Additionally, the shift of Walkspeed->normalspeed has removed some of the RP-ability of intentionally walking slower to accentuate injury/mood. Maybe with the aforementioned creep/walk/sprint system, it would be better, but overall the clunkiness, conflicts, and overall adjustment makes me feel like this isn't a worthwhile change.
I've also noticed myself and from others that the sprintspeed can be very jarring and sudden, and sometimes a bit too fast too quickly. Plus, with Kepori, the sprint bar lasting 50 tiles really takes away from the overall speed focus of the species.
The sprintspeed is nice sometimes when you're particularly rushing back to the ship or over somewhere else, but more often than not I've noticed myself sprinting a quarter of the way, and halfheartedly limping the rest nearly in stamcrit due to the slow recharge speed and buffer size.
If these issues could be addressed then I'd probably learn to love it. Until then though, I really don't see this system being enjoyable.

@thgvr
Copy link
Member Author

thgvr commented Sep 11, 2024

I'll come back to this

@thgvr thgvr closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Config Watch us shake head admins violently until this gets merged. DME Edit Sound USSR Anthem 2.66 MB file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants