Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature Feedback #3358

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Temperature Feedback #3358

merged 8 commits into from
Sep 18, 2024

Conversation

Gristlebee
Copy link
Contributor

@Gristlebee Gristlebee commented Sep 14, 2024

About The Pull Request

Original code and new alert icons by Rylie, a few bug fixes and modifications by me, and PRed on behalf of her.

The sweating alert icons specifically are from Citadel Station

Adds comfortable temperature ranges for species. Instead of the temp indicator only showing up when you hit dangerous temps and start taking damage, it will now show up once you exceed your comfortable range.

Being in temperature damage is now indicated by a sweating/fan overheat alert for organics and IPCs respectively in the case of overheating, or shivering if you're too cold.

Comfortable temp ranges are provisional, and Im open to changing them.

Why It's Good For The Game

Gives a bit more nuanced feedback on your temperature, and provides a transition state between from "you're a bit warm" to "you are now dying of heatstroke" instead of immediately going from fine to melting alive with no HUD warning.

Changelog

🆑 Rye-Rice, Gristlebee
add: Comfortable Temperature ranges
imageadd: Temperature HUD alerts
/:cl:

@Gristlebee Gristlebee requested a review from a team as a code owner September 14, 2024 08:23
@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Sep 14, 2024
@Orchidthederg
Copy link
Contributor

I've always wanted something like this. The first sign of "you're feeling cold" was just "oh yeah i have frostbite all over my body now haha"

Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after 2 years of development, hopefully it has been worth the wait

@rye-rice
Copy link
Member

this was so lovely seeing it ingame, poor sorothy were cold at room temperture
merging!

@rye-rice rye-rice added this pull request to the merge queue Sep 15, 2024
@thgvr thgvr removed this pull request from the merge queue due to a manual request Sep 15, 2024
@thgvr
Copy link
Member

thgvr commented Sep 15, 2024

Putting a winter coat on didn't make me not feel cold, I'd like stuff like that addressed so nobody feels like something is wrong/theyre going to die and the popup doesn't go away, as well as some more test merging to iron it out a bit

@thgvr thgvr added the Test Merge Required They'll have to do it for free. label Sep 15, 2024
@Gristlebee
Copy link
Contributor Author

Putting a winter coat on didn't make me not feel cold, I'd like stuff like that addressed so nobody feels like something is wrong/theyre going to die and the popup doesn't go away, as well as some more test merging to iron it out a bit

The code now takes into account if you're actively heating up or your temp is stabilizing, which should address this issue. Hopefully.

@rye-rice rye-rice added this pull request to the merge queue Sep 18, 2024
@rye-rice rye-rice removed this pull request from the merge queue due to a manual request Sep 18, 2024
@rye-rice rye-rice added this pull request to the merge queue Sep 18, 2024
Merged via the queue into shiptest-ss13:master with commit e08ed92 Sep 18, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Sep 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Original code and new alert icons by Rylie, a few bug fixes and
modifications by me, and PRed on behalf of her.

The sweating alert icons specifically are from Citadel Station

Adds comfortable temperature ranges for species. Instead of the temp
indicator only showing up when you hit dangerous temps and start taking
damage, it will now show up once you exceed your comfortable range.

Being in temperature damage is now indicated by a sweating/fan overheat
alert for organics and IPCs respectively in the case of overheating, or
shivering if you're too cold.

Comfortable temp ranges are provisional, and Im open to changing them.

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

Gives a bit more nuanced feedback on your temperature, and provides a
transition state between from "you're a bit warm" to "you are now dying
of heatstroke" instead of immediately going from fine to melting alive
with no HUD warning.
## Changelog

:cl: Rye-Rice, Gristlebee
add: Comfortable Temperature ranges
imageadd: Temperature HUD alerts
/:cl: 

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
craftxbox pushed a commit to craftxbox/shiptest that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Sprites A bikeshed full of soulless bikes. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants