Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakey tests rerunner #3395

Merged
merged 36 commits into from
Oct 7, 2024
Merged

Conversation

FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Sep 20, 2024

About The Pull Request

If only one test fails it will be rerun once, if that one passes it creates a bug report.
tgstation/tgstation#71519
tgstation/tgstation#80817
tgstation/tgstation#82790

Why It's Good For The Game

Its so fucking annyoing to deal with ship placment failing cause of auxmos
this will also probably document some bugs for us.

Changelog

🆑 FalloutFalcon, Mothblocks, Cyberboss
add: retry failed unit tests.
/:cl:

@keywordlabeler keywordlabeler bot added the WIP label Sep 20, 2024
@github-actions github-actions bot added Dependencies GitHub Our very own Babylon. labels Sep 20, 2024
@github-actions github-actions bot added the Code change Watch something violently break. label Sep 20, 2024
@FalloutFalcon FalloutFalcon added the Do Not Merge You probably made someone angry, or you're stopping people from getting angry. label Sep 20, 2024
@FalloutFalcon FalloutFalcon changed the title [WIP] flakey tests? [ci skip] flakey tests? Sep 20, 2024
@FalloutFalcon FalloutFalcon changed the title [ci skip] flakey tests? flakey tests rerunner Sep 20, 2024
@FalloutFalcon FalloutFalcon removed Do Not Merge You probably made someone angry, or you're stopping people from getting angry. WIP labels Sep 20, 2024
@FalloutFalcon FalloutFalcon marked this pull request as ready for review September 20, 2024 21:46
@FalloutFalcon FalloutFalcon requested a review from a team as a code owner September 20, 2024 21:46
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Oct 7, 2024
Merged via the queue into shiptest-ss13:master with commit 09ffd17 Oct 7, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
If only one test fails it will be rerun once, if that one passes it
creates a bug report.
tgstation/tgstation#71519
tgstation/tgstation#80817
tgstation/tgstation#82790
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Its so fucking annyoing to deal with ship placment failing cause of
auxmos
this will also probably document some bugs for us.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: FalloutFalcon, Mothblocks, Cyberboss
add: retry failed unit tests.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: FalloutFalcon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Dependencies GitHub Our very own Babylon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants