Planetary Lighting Colors #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Merge Conflict
|
guh?? |
github-actions
bot
added
the
Map Change
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Erika Fox <[email protected]>
FalloutFalcon
approved these changes
Oct 5, 2024
FalloutFalcon
requested changes
Oct 7, 2024
Sun-Soaked
previously approved these changes
Oct 26, 2024
Sun-Soaked
dismissed
their stale review
I want more input from our spritetainers before approving this pr.
Signed-off-by: Erika Fox <[email protected]>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
fuck it |
|
ill fix it later. |
Sun-Soaked
approved these changes
Oct 28, 2024
auto-merge was automatically disabled
October 29, 2024 20:33
Head branch was pushed to by a user without write access
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shiptest-server
pushed a commit
that referenced
this pull request
Oct 29, 2024
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <details><summary>screencaps</summary> <p>        </p> </details> Adds some planetary lighting defines and applies them to relevant planets. I had noticed I had an old pr that did this (among other things) so I ripped this out. Values are entirely subject to change I don't remember where I got them from and I'm not a so called 'colour theorist' As a coincidence planetary turf files are cleaned up a little by this. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game A little bit of atmosphere fluff. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: Some planets now have new lighting values. Please report back on if they are "Pleasant" /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Erika Fox <[email protected]> Signed-off-by: FalloutFalcon <[email protected]> Signed-off-by: Erika Fox <[email protected]> Co-authored-by: Bjarl <[email protected]> Co-authored-by: FalloutFalcon <[email protected]> Co-authored-by: rye-rice <[email protected]> Co-authored-by: Sun-Soaked <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
screencaps
Adds some planetary lighting defines and applies them to relevant planets. I had noticed I had an old pr that did this (among other things) so I ripped this out.
Values are entirely subject to change I don't remember where I got them from and I'm not a so called 'colour theorist'
As a coincidence planetary turf files are cleaned up a little by this.
Why It's Good For The Game
A little bit of atmosphere fluff.
Changelog
🆑
add: Some planets now have new lighting values. Please report back on if they are "Pleasant"
/:cl: