Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Shot RPG #3433

Merged
merged 7 commits into from
Oct 1, 2024
Merged

One Shot RPG #3433

merged 7 commits into from
Oct 1, 2024

Conversation

Erikafox
Copy link
Contributor

About The Pull Request

Adds a one-shot rocket launcher to the code. Adjusts the code in some places to support it being truly one shot. Also adds being able to draw on rocket launchers for mild entertainment.
Rye did the sprite.

Why It's Good For The Game

A disposable anti-armor tool is good for people who are poor and or frontiersmen.

Changelog

Rye, Erika
🆑
add: One-Shot Rocket Launcher. A quick solution to an armored problem.
add: You can now scribble profane things onto the tube of your rocket launcher. Use this power wisely.
imageadd: Rye: A sprite for a one-shot rocket launcher
/:cl:

@Erikafox Erikafox requested review from FalloutFalcon and a team as code owners September 25, 2024 21:02
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Sep 25, 2024
@rye-rice rye-rice added this pull request to the merge queue Oct 1, 2024
Merged via the queue into shiptest-ss13:master with commit bb2ab55 Oct 1, 2024
14 checks passed
@zimon9
Copy link
Contributor

zimon9 commented Oct 5, 2024

The main server crashed after a HEDP rocket was fired on rounds 2726 and 2727. Also, I don't think this should have devastation damage, as HE rockets already do enough damage to put anyone hit with one into critical condition. The same goes for anyone in exosuits.

I tested this on a local, both against a carbon mob with no ckey, and a carbon mob with my ckey, and both times, no runtime was thrown. I'm not quite sure what the issue might be.

@Erikafox
Copy link
Contributor Author

Erikafox commented Oct 5, 2024

Working on the dev damage and other assorted minor things soon.

As for the crash.

What the fuck

MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Oct 6, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Adds a one-shot rocket launcher to the code. Adjusts the code in some
places to support it being truly one shot. Also adds being able to draw
on rocket launchers for mild entertainment.
Rye did the sprite.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
A disposable anti-armor tool is good for people who are poor and or
frontiersmen.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog
Rye, Erika 
:cl:
add: One-Shot Rocket Launcher. A quick solution to an armored problem. 
add: You can now scribble profane things onto the tube of your rocket
launcher. Use this power wisely.
imageadd: Rye: A sprite for a one-shot rocket launcher
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 24, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Adds a one-shot rocket launcher to the code. Adjusts the code in some
places to support it being truly one shot. Also adds being able to draw
on rocket launchers for mild entertainment.
Rye did the sprite.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
A disposable anti-armor tool is good for people who are poor and or
frontiersmen.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog
Rye, Erika 
:cl:
add: One-Shot Rocket Launcher. A quick solution to an armored problem. 
add: You can now scribble profane things onto the tube of your rocket
launcher. Use this power wisely.
imageadd: Rye: A sprite for a one-shot rocket launcher
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants