-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
air alarms and more minor valor tweaks #3452
Merged
rye-rice
merged 9 commits into
shiptest-ss13:master
from
Jedi-Toothpaste:final-valor-passover
Oct 4, 2024
Merged
air alarms and more minor valor tweaks #3452
rye-rice
merged 9 commits into
shiptest-ss13:master
from
Jedi-Toothpaste:final-valor-passover
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Map Change
Tile placing is hard. Thank you for your service.
label
Sep 27, 2024
I will fix this by tomorrow; i'm not sure what is broken as of right Now. |
also removes a light switch
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 4, 2024
shiptest-server
pushed a commit
that referenced
this pull request
Oct 4, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Oct 6, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes a few outlasting issues with the Valor that I forgot from the previous pass. - Namely, adding air alarms and scrubbers to each room where applicable. ![image](https://github.com/user-attachments/assets/ebaba7a1-7f11-45b2-b195-13b367bd632d) - Adding intercoms to High-Traffic Areas - Adding Firelocks under the Cargo Blast Doors. - Adds a Medical Webbing to the HC's Locker, since they don't spawn with one. Also, finally, FINALLY FIXES the WORST part of the Valor. This being the security laptop in the way of the windoor in the armoury. THIS GAME BREAKING FEATURE has FINALLY been fixed. ![image](https://github.com/user-attachments/assets/23f9ddbf-6c72-45f4-9024-dc74ce366c7d) ## Why It's Good For The Game Having intercoms around the high traffic areas, hangar, surgery, mess should be helpful. Crew on the Valor naturally congregate in the Cargo Bay while patients generally gather outside of Surgery. Having a full scrubber and vent network with Air Alarms is a no brainer, again. The firelock change was a request for better RP, as Valor crews tend to like opening the blast doors as if they're opening the way for the Subshuttle to land, I find this to be great fun, and I believe the Ship Designers in-universe would put in a secondary saefty measure incase the holofield fails. - Also people can get crushed in the doors if you trip the fire alarm, this is funny. ## Changelog :cl: add: Added extra intercoms in high traffic areas on the Valor Class add: Added Firelocks underneath the Cargo-Bay Doors on the Valor Class add: Air Alarms, Scrubbers and Vents to every applicable room /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Dec 24, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes a few outlasting issues with the Valor that I forgot from the previous pass. - Namely, adding air alarms and scrubbers to each room where applicable. ![image](https://github.com/user-attachments/assets/ebaba7a1-7f11-45b2-b195-13b367bd632d) - Adding intercoms to High-Traffic Areas - Adding Firelocks under the Cargo Blast Doors. - Adds a Medical Webbing to the HC's Locker, since they don't spawn with one. Also, finally, FINALLY FIXES the WORST part of the Valor. This being the security laptop in the way of the windoor in the armoury. THIS GAME BREAKING FEATURE has FINALLY been fixed. ![image](https://github.com/user-attachments/assets/23f9ddbf-6c72-45f4-9024-dc74ce366c7d) ## Why It's Good For The Game Having intercoms around the high traffic areas, hangar, surgery, mess should be helpful. Crew on the Valor naturally congregate in the Cargo Bay while patients generally gather outside of Surgery. Having a full scrubber and vent network with Air Alarms is a no brainer, again. The firelock change was a request for better RP, as Valor crews tend to like opening the blast doors as if they're opening the way for the Subshuttle to land, I find this to be great fun, and I believe the Ship Designers in-universe would put in a secondary saefty measure incase the holofield fails. - Also people can get crushed in the doors if you trip the fire alarm, this is funny. ## Changelog :cl: add: Added extra intercoms in high traffic areas on the Valor Class add: Added Firelocks underneath the Cargo-Bay Doors on the Valor Class add: Air Alarms, Scrubbers and Vents to every applicable room /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes a few outlasting issues with the Valor that I forgot from the previous pass.
Adding intercoms to High-Traffic Areas
Adding Firelocks under the Cargo Blast Doors.
Adds a Medical Webbing to the HC's Locker, since they don't spawn with one.
Also, finally, FINALLY FIXES the WORST part of the Valor. This being the security laptop in the way of the windoor in the armoury. THIS GAME BREAKING FEATURE has FINALLY been fixed.
Why It's Good For The Game
Having intercoms around the high traffic areas, hangar, surgery, mess should be helpful. Crew on the Valor naturally congregate in the Cargo Bay while patients generally gather outside of Surgery.
Having a full scrubber and vent network with Air Alarms is a no brainer, again.
The firelock change was a request for better RP, as Valor crews tend to like opening the blast doors as if they're opening the way for the Subshuttle to land, I find this to be great fun, and I believe the Ship Designers in-universe would put in a secondary saefty measure incase the holofield fails. - Also people can get crushed in the doors if you trip the fire alarm, this is funny.
Changelog
🆑
add: Added extra intercoms in high traffic areas on the Valor Class
add: Added Firelocks underneath the Cargo-Bay Doors on the Valor Class
add: Air Alarms, Scrubbers and Vents to every applicable room
/:cl: